From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4AA32DCBEB for ; Tue, 30 Dec 2025 00:50:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767055821; cv=none; b=u8r2eCQQcy+1CwnF0JjgpjpVx+lJtFAfE6LbiydMSTuJuD/m0eVwunspVH/6iz0fuyCpDbF6etEvprc3UhKdrM8ehABN9L1M1Y8nFEsfH4fs4AeVACoXBBPoLJ5RiTjHH22nTCgaPGOAbxJlEMoXPsdyrzIvZt5m9nBLWRjy3Qs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767055821; c=relaxed/simple; bh=NLGqiqnGiqlrrX/Jn96o+ScgglAgd2yYpoAiSl42MiY=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=SUNpqYkb+FOrCVlwXCVPlMrngm0wXgo5JQdxwgRny2pTsiUPbOvA4ZI90XxXjMkwvmhFAwfsUQ7IrLzyAOpTY1wauIBaBLn+15tOXAVe+dlNlU9LBc3dz4C5MQEqHHBDD3N60sudlUFylELORkZy4Fo/tRW6EpsGFP5axCDVuDU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=3AjcRlK3; arc=none smtp.client-ip=209.85.222.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="3AjcRlK3" Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-8b2d56eaaceso1147019485a.0 for ; Mon, 29 Dec 2025 16:50:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1767055819; x=1767660619; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=GmB4IaDnBQbcN0DZ+rksSqBNuUUAz/TbWbwNTx7EuUk=; b=3AjcRlK3SolHiP6FwTVy0qkjdVawiSYdrM4SRmoxEH7ZIthziy9bs+8+Tleq3qEQQ7 Nks7BSFNUNB/9TYe74rcCNbqNJ9zfflipkoOVcZenak3+FwF2h/ntezKVZzsolfZCDGt 75CrAVu5ytJlNxQ2IDoLEd4QNsACwwndb/6jiCAIadPM4/iJBUzyj+PzNL9KnSFqn8cY 1GC4ZTg5dQBh7me8rOwAVI8eO3Is8vp/GC0QtJR8nj/0kDzfvQOD6htnMe8BwBQ9I1X0 snXuiAbvkkXnwy/8XXMLVCLQqQeTYoZ1j4eAAnaAPK8YuuNKcVVUmCxyBoBnOYRbK0S8 s7jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767055819; x=1767660619; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GmB4IaDnBQbcN0DZ+rksSqBNuUUAz/TbWbwNTx7EuUk=; b=YPJ1dXVYoJ+6Zg8LQYdvYcK7lp7B1qmhYRTlq+B6qdMOf64gvfR4yTqcg59Aol3ZMA HW/bjdjkUqc1dpBdLxJ2UQMa2uuTByEg30zgoVwaKKrf62NaafBbZI9czxPN2zEVKRmQ z4d0PVMT/YNHDexJuLJ9/f2KgRn/N4zBfQ3chseyQGD/s/hVa1GpmNRAsI0pho046sw+ afsIj1m3mu3B2TS1wkvM0ngG8bXytFQR477CYCRn82+2GAH7saQg17tufPnhEOpvM9y4 HW2DDPvZC0qc6UyZ/UhFdcBTYOqmb3Vzv9o9sr203ako0qoB9ks2r5FSLoF0Ma7G71D1 zosg== X-Forwarded-Encrypted: i=1; AJvYcCUUA8klKUnyGWsOlhjdZbAiJJFnjc9t+7QnUvB3U/UESTChdVWjuewZtKMltxUR9UZmythn7F33UCZUwZ0=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3dJZ6RwtbnoIZOx83HUXlU8EgN+QhY+6CvCnYafmKDMAE/Fjp JPwXuTSHsQh2nGv+CutfJSOPgXFDpr+gNBD/FCkGKwjBGvO1YK/BhBY/c3KWfQA5/Gs= X-Gm-Gg: AY/fxX7uSLGNdJ+dmZ9QhOtifp0/wnjSwPgJ/pVLajzmilUmIc4m9Ra4Elc1auPbSpG CMr9+WJpvktahkcXjcRlERM8Nj60yxeTeEjCJovzB+ooBbsYEfpa1/rtb5xJT3iGeQpOoj3197I NxuO62N6LNrdYSbxAQEBmtAhDL40S44BkHlkFCxm8iEmSNIkz7RGBboq4KpxxHG2rKbqrW09Mil Mqcb30oMiaXB6geAb3cJn1mIyzBorBpNVHtVYTMuV2xOfQOIVLWoqUhTb/N8eFmsV+ACkRdua51 oeZZieOK5ugOoStK2B5oOXtcOxHmeWnwX38qh4GCPyX50pHKdT59eUAGnBObPazA1J75HRl7P7Q cZsf6WobLiAhdSWHdZ0LAKOFBtzLHRZONyHb8paaneNj3zp1GgQLaEVROGTsJH0a2VtUvjLNtj8 E/FxmQZi9gbOzR+4dphwIAki1Amw7+aSDh4z00JGYmmd6nOfamJqk= X-Google-Smtp-Source: AGHT+IEqx11qIx1fExQIVt8RthOfBqirsnQypMP24TGrYewLCr/1F0cNPLqYX2PYXTzLqSFzTJNaAQ== X-Received: by 2002:a05:620a:2950:b0:8b2:f269:f8a1 with SMTP id af79cd13be357-8c08fabf8f5mr5613056285a.71.1767055818602; Mon, 29 Dec 2025 16:50:18 -0800 (PST) Received: from [172.22.22.28] (c-75-72-117-212.hsd1.mn.comcast.net. [75.72.117.212]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8c096891558sm2482817485a.15.2025.12.29.16.50.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Dec 2025 16:50:18 -0800 (PST) Message-ID: <546ab443-d0b1-4f21-856c-c74e84511d06@riscstar.com> Date: Mon, 29 Dec 2025 18:50:17 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Alex Elder Subject: Re: [PATCH v2 3/3] reset: spacemit: fix auxiliary device id To: Yixun Lan , Stephen Boyd , Michael Turquette , Philipp Zabel Cc: Guodong Xu , Inochi Amaoto , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev References: <20251226-06-k1-clk-common-v2-0-28b59418b4df@gentoo.org> <20251226-06-k1-clk-common-v2-3-28b59418b4df@gentoo.org> Content-Language: en-US In-Reply-To: <20251226-06-k1-clk-common-v2-3-28b59418b4df@gentoo.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/26/25 12:55 AM, Yixun Lan wrote: > Due to the auxiliary register procedure moved to ccu common module, > the auxiliary device id need to be adjusted, otherwise reset driver > will fail to probe. > > Signed-off-by: Yixun Lan > --- > drivers/reset/reset-spacemit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/reset/reset-spacemit.c b/drivers/reset/reset-spacemit.c > index e1272aff28f7..8922e14fa836 100644 > --- a/drivers/reset/reset-spacemit.c > +++ b/drivers/reset/reset-spacemit.c > @@ -278,7 +278,7 @@ static int spacemit_reset_probe(struct auxiliary_device *adev, > > #define K1_AUX_DEV_ID(_unit) \ > { \ > - .name = "spacemit_ccu_k1." #_unit "-reset", \ > + .name = "spacemit_ccu." _K_RST(_unit), \ > .driver_data = (kernel_ulong_t)&k1_ ## _unit ## _reset_data, \ > } The above macro is named K1_AUX_DEV_ID(). Why don't you define K3_AUX_DEV_ID(), which could use "k3" in its name? Anyway, if you go this route I suggest you drop "K1_" from the name of this macro. -Alex > >