From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753263AbcLFNhP (ORCPT <rfc822;w@1wt.eu>);
        Tue, 6 Dec 2016 08:37:15 -0500
Received: from mout.kundenserver.de ([217.72.192.75]:58839 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753178AbcLFNhM (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 6 Dec 2016 08:37:12 -0500
To: Wolfgang Ocker <weo@reccoware.de>
In-Reply-To: 
Cc: Fabio Estevam <fabio.estevam@nxp.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
From: Stefan Wahren <stefan.wahren@i2se.com>
Subject: Re: [PATCH] serial: mxs-auart: support CMSPAR termios cflag
Message-ID: <546f7a46-df39-778f-e148-75862f426ff2@i2se.com>
Date: Tue, 6 Dec 2016 14:36:16 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:o4m9BpVjkyGjKuRrvhHMynojqlwf2MrAT2R0Xxn4Qvzf90ECQtD
 PXW6tNGhAtOH02lAD6cebaWPYUiEnsm04zZmyKw4zNzeyNH3+wtVOh5FmjyBbxaMIBLUejH
 9gFm1EOpJ1Cum9B3MR51Ag3A2CYZzQrlYgp5Uux6RGyzUwLnRit6Tv51OIc+UGUnVuy8CNE
 pq0YdCEE0Spcx9GtUkK/w==
X-UI-Out-Filterresults: notjunk:1;V01:K0:cw6zT981/Ww=:aq5SbEuPMaO5H9UWPrKBlv
 FHTNI7//94hYTuuR4qfsIJFXXEYBwKAeHqvjBqw46WKP7qssJFODDQwLmoNpNSjbHRb2boQtQ
 BEwUCBGpW2b1DO19kihnSLKkt/yEc2JB3pdWCo06jtMOn0YzpCuHjcuzqMXYzfrONlhsUP1nc
 H2tAh/lZJIe/IJsbQf8V6FD7nicQ96TKvPzCUHbvXL4lcUeE/gPFX3qdJSPe1HoBVVFB65tqU
 vSPDUP2xAEtckxoAjlLSyydHXIV8u8EeCtWoxJqxvaWTqppLKRECNpWBfh2iI1xvDR2/P8Fkm
 s9vfTezs08teM32/B2Ws3Vgf312b1K0JN8YQRrw1+Hdv/XnfqItZTdw/8QZLvP1odTXU7Ii6p
 SkgBbMoUU7/+a20l4cvOcTxiipZSqrm4ZcAQ7Zte9g/zIj+UygxPykfr9KNkv42wyaBa6+SEj
 2aFVgXVvdS5/EYJiMEG1cE3DabFXCo2PFiTe33PaBl1p80AfbfvHsoS3Qa3+G6UqFz4WJBzFK
 wed6EzspilahtrfF3baGzPyjwaodN66RTbDrIB8h7g04s6SzFRATBySBbl81/Rw9vS2HZ6LJi
 zsma+j7mmb7rW2aKPbHqti6KKyY1invFN99aQW50FfgG7ih7uu4y0FA6eBkClFkekO6L9AtAv
 xBfN81nI/ydYjzp1/EHF04Ms+T5Qa5ifeYShgDQYLQSSgBwzQXPL8B/Z5RRPXtrf/Qz4iuk1e
 WbTqgJEbuzzTj2D0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Wolfgang,

> --- a/drivers/tty/serial/mxs-auart.c
> +++ b/drivers/tty/serial/mxs-auart.c
> @@ -95,6 +95,7 @@
>  #define AUART_LINECTRL_BAUD_DIVFRAC_SHIFT	8
>  #define AUART_LINECTRL_BAUD_DIVFRAC_MASK	0x00003f00
>  #define AUART_LINECTRL_BAUD_DIVFRAC(v)		(((v) & 0x3f) << 8)
> +#define AUART_LINECTRL_SPS			(1 << 7)
>  #define AUART_LINECTRL_WLEN_MASK		0x00000060
>  #define AUART_LINECTRL_WLEN(v)			(((v) & 0x3) << 5)
>  #define AUART_LINECTRL_FEN			(1 << 4)
> @@ -1010,10 +1011,12 @@ static void mxs_auart_settermios(struct uart_port *u,
> 	ctrl |= AUART_LINECTRL_WLEN(bm);
> 
> 	/* parity */
> -	if (cflag & PARENB) {
> +	if (cflag & (PARENB|CMSPAR)) {

does it make sense to enable stick parity in case parity is disabled?

The i.MX28 reference manual doesn't describe this case explicit.

Stefan