mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Denis Benato <denis.benato@linux.dev>
To: MIrian Shilakadze <mirian@msh.ge>, 'Jiri Kosina' <jikos@kernel.org>
Cc: 'Benjamin Tissoires' <bentiss@kernel.org>,
	'Dmitry Torokhov' <dmitry.torokhov@gmail.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Derek J. Clark" <derekjohn.clark@gmail.com>
Subject: Re: [PATCH v5 0/2] HID: flydigi: add support for vader 5 pro
Date: Fri, 6 Nov 2026 01:03:25 +0100	[thread overview]
Message-ID: <546fd97f-bbd6-4867-b86c-9a4a44ca44c6@linux.dev> (raw)
In-Reply-To: <befcd715-ecc8-463d-9617-a269dc7c62cf@msh.ge>


On 11/6/26 00:51, MIrian Shilakadze wrote:
> On 9/15/26 9:14 PM, Denis Benato wrote:
>> To make optimal use of this device the xpad driver should not
>> bind to the controller, and this is the case for more than just
>> this controller as Derek told me, so I added some basic infrastructure
>> to use the best available driver for the device.
> Hi Denis,
Hi Mirian,

Thanks for your intrest!
> I gave v5 a try with a Flydigi Apex 5 (37d7:2501, wired, firmware
> 0x7045). It uses the same protocol as the Vader 5 Pro, as far as I can
> tell. The difference I found is the report ID: 0x03 for output and 0x04
> for input. SDL already handles this.

That's easy enough, we can do it.

> One thing came up that probably affects the Vader too. The driver
> ignores the third-party flag in the status reply (the "Allow third-party
> apps to take over mappings" setting in Space Station). SDL checks it for
> all V2 pads, the Vader 5 Pro included. On my Apex 5, with the flag off,
> acquire is ACKed but no 0xef reports come and nothing tells the user
> why. After setting it with 0x11 (ff ff ff ff 01), the stream starts and
> M1-M4 work. It stays on after a USB replug. I tested this by hand over
> hidraw.
>
> Should the driver check the flag and warn or turn it on itself with 0x11?

I think it should have a sysfs property allowing to change it and also set
the most reasonable value at probe.

> Supporting the Apex 5 looks small from what I have seen so far.
> raw_event already skips the report ID. The descriptor check would need
> to learn this layout (output ID 0x03), plus the ID in the hid and xpad
> tables. Would you like that as part of this series or as a separate
> patch later? I'm happy to write and test it.

I have actually a better idea: the friend of mine with the actual hardware
has discovered that a recent firmware update changed things and he
tasked an llm to properly handle the apex 6.

Since you two have the whole range of hardware and SDL has working
code why don't you take over? It would surely be better than me making
the bridge since you do own hardware and care about it.

Let me know if you are interested and I will be more than happy to
make that happen!

Best regards,
Denis

> Thanks,
> Mirian Shilakadze
>

  reply	other threads:[~2026-11-06  0:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05 23:51 MIrian Shilakadze
2026-11-06  0:03 ` Denis Benato [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-09-15 17:14 Denis Benato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546fd97f-bbd6-4867-b86c-9a4a44ca44c6@linux.dev \
    --to=denis.benato@linux.dev \
    --cc=bentiss@kernel.org \
    --cc=derekjohn.clark@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mirian@msh.ge \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®