From: Bart Van Assche <bvanassche@acm.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com
Cc: alim.akhtar@samsung.com, avri.altman@wdc.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Anjana Hari <quic_ahari@quicinc.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] scsi: ufs: core: Do not set link to OFF state while waking up from hibernation
Date: Mon, 22 Jul 2024 10:57:30 -0700 [thread overview]
Message-ID: <54704229-221f-4724-b386-48c39ee1290c@acm.org> (raw)
In-Reply-To: <20240718170659.201647-1-manivannan.sadhasivam@linaro.org>
On 7/18/24 10:06 AM, Manivannan Sadhasivam wrote:
> UFS link is just put into hibern8 state during the 'freeze' process of the
> hibernation. Afterwards, the system may get powered down. But that doesn't
> matter during wakeup. Because during wakeup from hibernation, UFS link is
> again put into hibern8 state by the restore kernel and then the control is
> handed over to the to image kernel.
>
> So in both the places, UFS link is never turned OFF. But
> ufshcd_system_restore() just assumes that the link will be in OFF state and
> sets the link state accordingly. And this breaks hibernation wakeup:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2024-07-22 17:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-18 17:06 Manivannan Sadhasivam
2024-07-22 17:57 ` Bart Van Assche [this message]
2024-07-23 0:32 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54704229-221f-4724-b386-48c39ee1290c@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=quic_ahari@quicinc.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®