From: Valdis.Kletnieks@vt.edu
To: Dan Magenheimer <dan.magenheimer@oracle.com>
Cc: linux-kernel@vger.kernel.org
Subject: zcache - trivial tweak to build-time error message wording
Date: Wed, 31 Aug 2011 16:23:16 -0400 [thread overview]
Message-ID: <54715.1314822196@turing-police.cc.vt.edu> (raw)
Clarify that the requirement is "at least one of" - the error message could
potentially be read as both being required.
Yes, the line is over 80 chars. You can't get 79 chars of text and a #error
into 80 chars :)
Patch against linux-next-20110831
Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
--- linux-next/drivers/staging/zcache/zcache-main.c.dist 2011-08-31 13:31:27.054696837 -0400
+++ linux-next/drivers/staging/zcache/zcache-main.c 2011-08-31 16:16:46.055659964 -0400
@@ -34,7 +34,7 @@
#include "../zram/xvmalloc.h" /* if built in drivers/staging */
#if (!defined(CONFIG_CLEANCACHE) && !defined(CONFIG_FRONTSWAP))
-#error "zcache is useless without CONFIG_CLEANCACHE or CONFIG_FRONTSWAP"
+#error "zcache is useless without at least one of CONFIG_CLEANCACHE or CONFIG_FRONTSWAP"
#endif
#ifdef CONFIG_CLEANCACHE
#include <linux/cleancache.h>
next reply other threads:[~2011-08-31 20:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-31 20:23 Valdis.Kletnieks [this message]
2011-09-01 14:41 ` Dan Magenheimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54715.1314822196@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=dan.magenheimer@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®