From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Josh Wu <josh.wu@atmel.com>
Cc: linux-media@vger.kernel.org, m.chehab@samsung.com,
linux-kernel@vger.kernel.org, g.liakhovetski@gmx.de
Subject: Re: [PATCH 1/2] media: v4l2-image-sizes.h: add SVGA, XGA and UXGA size definitions
Date: Tue, 25 Nov 2014 11:34:23 +0100 [thread overview]
Message-ID: <54745B2F.70003@samsung.com> (raw)
In-Reply-To: <1416905668-23029-1-git-send-email-josh.wu@atmel.com>
Hi Josh,
On 25/11/14 09:54, Josh Wu wrote:
> Add SVGA, UXGA and XGA size definitions to v4l2-image-sizes.h.
> The definitions are sorted by alphabet order.
>
> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> ---
> include/media/v4l2-image-sizes.h | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/include/media/v4l2-image-sizes.h b/include/media/v4l2-image-sizes.h
> index 10daf92..c70c917 100644
> --- a/include/media/v4l2-image-sizes.h
> +++ b/include/media/v4l2-image-sizes.h
> @@ -25,10 +25,19 @@
> #define QVGA_WIDTH 320
> #define QVGA_HEIGHT 240
>
> +#define SVGA_WIDTH 800
> +#define SVGA_HEIGHT 680
I think this should be 600. With that fixed, for both patches:
Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> #define SXGA_WIDTH 1280
> #define SXGA_HEIGHT 1024
>
> #define VGA_WIDTH 640
> #define VGA_HEIGHT 480
>
> +#define UXGA_WIDTH 1600
> +#define UXGA_HEIGHT 1200
> +
> +#define XGA_WIDTH 1024
> +#define XGA_HEIGHT 768
> +
> #endif /* _IMAGE_SIZES_H */
--
Regards,
Sylwester
next prev parent reply other threads:[~2014-11-25 10:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 8:54 Josh Wu
2014-11-25 8:54 ` [PATCH 2/2] media: ov2640: use the v4l2 " Josh Wu
2014-11-27 21:10 ` Guennadi Liakhovetski
2014-11-25 10:34 ` Sylwester Nawrocki [this message]
2014-11-26 2:06 ` [PATCH 1/2] media: v4l2-image-sizes.h: add SVGA, XGA and UXGA " Josh Wu
2014-11-25 22:23 ` Guennadi Liakhovetski
2014-11-27 3:21 ` Josh Wu
2014-11-27 20:13 ` Guennadi Liakhovetski
2015-01-28 2:09 ` Josh Wu
2015-01-28 20:49 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54745B2F.70003@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=g.liakhovetski@gmx.de \
--cc=josh.wu@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome