From: Florian Fainelli <f.fainelli@gmail.com>
To: Horatiu Vultur <horatiu.vultur@microchip.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, lars.povlsen@microchip.com,
Steen.Hegelund@microchip.com, daniel.machon@microchip.com,
UNGLinuxDriver@microchip.com
Cc: u.kleine-koenig@pengutronix.de, rmk+kernel@armlinux.org.uk,
vladimir.oltean@nxp.com, jacob.e.keller@intel.com,
yuehaibing@huawei.com, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: sparx5: Add spinlock for frame transmission from CPU
Date: Tue, 13 Feb 2024 09:26:45 -0800 [thread overview]
Message-ID: <5476743f-3648-4038-97f8-a9df22c0f507@gmail.com> (raw)
In-Reply-To: <20240213121705.4070598-1-horatiu.vultur@microchip.com>
On 2/13/24 04:17, Horatiu Vultur wrote:
> Both registers used when doing manual injection or fdma injection are
> shared between all the net devices of the switch. It was noticed that
> when having two process which each of them trying to inject frames on
> different ethernet ports, that the HW started to behave strange, by
> sending out more frames then expected. When doing fdma injection it is
> required to set the frame in the DCB and then make sure that the next
> pointer of the last DCB is invalid. But because there is no locks for
> this, then easily this pointer between the DCB can be broken and then it
> would create a loop of DCBs. And that means that the HW will
> continuously transmit these frames in a loop. Until the SW will break
> this loop.
> Therefore to fix this issue, add a spin lock for when accessing the
> registers for manual or fdma injection.
>
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
Any reason you targeted 'net-next' rather than 'net', as this appears to
be clearly a bug fix here?
--
Florian
next prev parent reply other threads:[~2024-02-13 17:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 12:17 Horatiu Vultur
2024-02-13 16:22 ` Daniel Machon
2024-02-13 17:26 ` Florian Fainelli [this message]
2024-02-14 8:14 ` Horatiu Vultur
2024-02-14 15:09 ` Jakub Kicinski
2024-02-15 8:07 ` Horatiu Vultur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5476743f-3648-4038-97f8-a9df22c0f507@gmail.com \
--to=f.fainelli@gmail.com \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=daniel.machon@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horatiu.vultur@microchip.com \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vladimir.oltean@nxp.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®