From: Hans Verkuil <hansverk@cisco.com>
To: anjana s <anjanasasindran123@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
joe@perches.com, m.chehab@samsung.com, hans.verkuil@cisco.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers:staging:media:omap24xx:v4l2-int-device.h: Added a '*' before ')'--(parenthesis closing)
Date: Mon, 01 Dec 2014 14:06:13 +0100 [thread overview]
Message-ID: <547C67C5.500@cisco.com> (raw)
In-Reply-To: <CABU2W3oMGH9v0+mjw+s+nRpbOj7pxdVvdMWhnmNgEwKPJ2VSmg@mail.gmail.com>
On 12/01/2014 02:01 PM, anjana s wrote:
> Should I do anything on this further?
No. The driver will disappear in 3.19, so there is no point to this patch.
BTW, always check the Kconfig to see if a staging driver is marked deprecated.
If so, then patches are pointless.
Regards,
Hans
> Looking forward to hear from you.
>
> On Mon, Dec 1, 2014 at 2:20 PM, Dan Carpenter <dan.carpenter@oracle.com <mailto:dan.carpenter@oracle.com>> wrote:
>
> On Sun, Nov 30, 2014 at 04:28:02PM +0530, Anjana Sasindran wrote:
> > This patch fix a checkpatch.pl <http://checkpatch.pl> error:
> >
> > ERROR: space prohibited before ')' parenthesis closing
> >
> > Signed-off-by: Anjana Sasindran <anjanasasindran123@gmail.com <mailto:anjanasasindran123@gmail.com>>
> > ---
> > drivers/staging/media/omap24xx/v4l2-int-device.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/media/omap24xx/v4l2-int-device.h b/drivers/staging/media/omap24xx/v4l2-int-device.h
> > index 0286c95..9490595 100644
> > --- a/drivers/staging/media/omap24xx/v4l2-int-device.h
> > +++ b/drivers/staging/media/omap24xx/v4l2-int-device.h
> > @@ -292,7 +292,7 @@ V4L2_INT_WRAPPER_1(s_video_routing, struct v4l2_routing, *);
> >
> > V4L2_INT_WRAPPER_0(dev_init);
> > V4L2_INT_WRAPPER_0(dev_exit);
> > -V4L2_INT_WRAPPER_1(s_power, enum v4l2_power, );
> > +V4L2_INT_WRAPPER_1(s_power, enum v4l2_power, *);
>
> Wait, what? The changelog for this is not clear. This looks like
> either a bug fix or a bug introducer.
>
> This driver has been deleted in linux-next anyway so I guess it doesn't
> matter. Please work against linux-next.
>
> regards,
> dan carpenter
>
>
>
>
> --
> Anjana S
> Amrita School of Engineering
> anjanasasindran123@gmail.com <mailto:anjanasasindran123@gmail.com>
>
>
>
prev parent reply other threads:[~2014-12-01 13:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-30 10:58 Anjana Sasindran
2014-12-01 8:17 ` Hans Verkuil
2014-12-01 8:50 ` Dan Carpenter
[not found] ` <CABU2W3oMGH9v0+mjw+s+nRpbOj7pxdVvdMWhnmNgEwKPJ2VSmg@mail.gmail.com>
2014-12-01 13:06 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547C67C5.500@cisco.com \
--to=hansverk@cisco.com \
--cc=anjanasasindran123@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hans.verkuil@cisco.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome