From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F09BD1E32D3 for ; Fri, 28 Nov 2025 03:55:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764302143; cv=none; b=mRbiwv0ftjUeDppWWX1sTC51knMc1Y18kelBmVbMpivQRJARcR8fY0XbWRrtP1IsIpIyYSDM4BJofDxzDjeLcWLYTpW0JrDVMX/uUXCSqelUAvzWy6WeEQ/Akn6J2yzpVDghA5jl6yFhYRTgaVdE+5Bpo9U8zlQAaZH+e2qqcq8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764302143; c=relaxed/simple; bh=IeTUGQBihXldKwxVZRfC3Ibaus9jWGPghfgg6wC9iwU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FvHvzXrVHEITRS7xFBdCpShBhbQ94T3Q8VCfjepmFRGzK8p3dL6dJRb2fkikNBjPljWLly9N7/f0i6+Uk09rqgEGRwCzbnPpao0bUE8Jti+kpzgpLLomcgShHpE+fjnDqirE1XkUrjjOj1Ui16n1RSbi0fv+CNrvyzbSHTah3vk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=obqZA9V1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=a3Zegj4q; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="obqZA9V1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="a3Zegj4q" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5ARMkfPf2101582 for ; Fri, 28 Nov 2025 03:55:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= g6WPJq973eX+KP/yKOjzdDcbbmr+wFA5V2WCdo5WMyI=; b=obqZA9V1TCHI6pPH jzCmZKRVUgL2G8nwVIwZQ5pXdQzFWGDrMZ3utrYGTOKkSqdoEhq+Rj7PBStEErcU M6BKysL++t8W5WAbq6vUZdsp70JW5t/u2p0/5rfSQtkjV4fi/rtf0lDV5++lO2kr ZpoSWRzo0l2RnfdPxB9y9h1lh01z8T78jTPeYE+zdTyOfgmiRjLKaoS1sEydVGFA 3dc1Nu27Folptl8uw9zt4oVTXy/z0iD5+deX5lPLZeck67giXQJglKxJ6Ung44GB NfF9Ift3ATheLudB3sdZ9qV1zVzs/lNfjMr/YtPSpdGXnxzASKVCuWCGPRgkZID7 2ECR/g== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4apnud9sge-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 28 Nov 2025 03:55:40 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-343bf6ded5cso2111190a91.0 for ; Thu, 27 Nov 2025 19:55:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764302139; x=1764906939; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=g6WPJq973eX+KP/yKOjzdDcbbmr+wFA5V2WCdo5WMyI=; b=a3Zegj4qVCshqMbzypnCKCZ0IddY280n3+f4kDVnKmnN8YqN96KYcHNfIn5RTgucLr jwyEo/FAR50MXjD4kjQS24pAOG9FuQpXmsXI0u1tBK7BR9CVGzd2zMEuwKkuGTzhTt0L GDE+tHYrxAswZVW5rN+mFq+HoQQZF7OYqiIBC08hhQzqAzoOxnvi5pgEK+Pjw+S8HPym BGInwb0yLaqjDGxP06UbpRruvtivt1aW7Jq4azwo7YP+PyStHWViQB5GGgR+gkCsJNhK usOQJEZszcS0dFD8C464d2vs71CmkrPq8PcImMRzga/v7Ae6Gh2b8twvyJaIzGLFnCAi 2SHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764302139; x=1764906939; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=g6WPJq973eX+KP/yKOjzdDcbbmr+wFA5V2WCdo5WMyI=; b=BxoMKJi+SnZa1RcDJcqjQlZCJjJSJwN2NFcoxveKTx9JkSbA9muyfnsoqrpX0kOKNH +/yuvg/pTSFF/SEu6dWORQgNqw62+86rGey0JSmsiMySZlT2LFiEu67dtuHSmSFUAui3 m6W8of3/9lzCqoJJOaUysv56io9qXlWSUdKCy0ya54mKBlt6oCPGllfjAJ/B5kbKyuSD AY92hYlh1yiOYh3EJKezrtpT2kQ2FOqE0bbHA5RU6lSwoQHUrMw9CLgGJwWR5kyQwkV6 p7Af6Ho+9oYwPyEL2aPw99a6A6TeFZ8em3x3Yhc3BdjQ2ARj4LWIfzs+B4Z5qY9DJKkv t3YA== X-Forwarded-Encrypted: i=1; AJvYcCWPvjybhwbPqn2DIl7e3mK/wHHpt7keP3N1666PEBGyW204rMrOrbsf7fdt7kMoa/5xdENOgFzbI4ygvj4=@vger.kernel.org X-Gm-Message-State: AOJu0YxH18ETtEwetvNpxI3Z8t/l2euowvraQE/rPuK+Lj1G9rGcPe0H r+L9XuxLW1bR2W0MbTSNlR/AjQtf28XgOQJz8NdDAWzeAF6Kaq/4SAob1Q+5YxrvgwoLzNTMCyZ vsvgQDsCyQ9O3DcBBw14sS3WJIx/wqMNDc6xYc7I/joQUaj/HGqU211s8LmS7E9XLVnk= X-Gm-Gg: ASbGnctAfGKZSkBD1BoMxQrq+s1gSwh9zpgJ+dlh3w61BMAZcIcvxUnFuy/T8JqDihd +5hPfuykJHja23pZJlZ8raeOYHmNMUArZ1+ktYyLBBgGG/5H7uTaayTuar95mRUvCES+VNqz4T6 M6mT3m5TGgq3+jWrRLVsVoWQPghBZNrxGO+WbDUOx4ofirA/9LxmWlnmiV6uKCPEV4Z02aOMZKH /sLw6+j80i1IrInXw0kW7LGe+T4R1QSw1g21s9bHRZQb58/8OEGkmvowXXPCIwEUvopLNIboVkc ZWdxuGEjJY0iPTD4PJPvFboOkkEGN0H/dS8HK/6lToIyZu1ZG/1Dks4SOI3oJ4pyN+HqAr20Kh/ ZMG1DHX57pG/QBNJE/LrflhE4CJ3oVwxdgiPFeA== X-Received: by 2002:a17:90b:2d4c:b0:340:b06f:712e with SMTP id 98e67ed59e1d1-34733f22104mr23805108a91.19.1764302138931; Thu, 27 Nov 2025 19:55:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IFzaTpzvVEcgi4SvBYVDFQZwxQ3RaZ++NVOh3Hp4KAq7hTbG7ZICn/N06Wl4DveGKglzbKmFA== X-Received: by 2002:a17:90b:2d4c:b0:340:b06f:712e with SMTP id 98e67ed59e1d1-34733f22104mr23805074a91.19.1764302138406; Thu, 27 Nov 2025 19:55:38 -0800 (PST) Received: from [10.217.217.147] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3476a7c2ce5sm6884455a91.14.2025.11.27.19.55.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Nov 2025 19:55:37 -0800 (PST) Message-ID: <547b0b85-d353-4bd1-9f25-6876bed281e6@oss.qualcomm.com> Date: Fri, 28 Nov 2025 09:25:31 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 8/8] clk: qcom: gcc-glymur: Update the SDCC RCGs to use shared_floor_ops To: Jagadeesh Kona , Bjorn Andersson , Michael Turquette , Stephen Boyd , Vinod Koul , Konrad Dybcio , Dmitry Baryshkov , Taniya Das , Melody Olvera , Ajit Pandey , Imran Shaik , Luca Weiss , Rajendra Nayak , Abel Vesa , Sibi Sankar , Dmitry Baryshkov , Konrad Dybcio Cc: Ajit Pandey , Imran Shaik , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251127-sdcc_shared_floor_ops-v2-0-473afc86589c@oss.qualcomm.com> <20251127-sdcc_shared_floor_ops-v2-8-473afc86589c@oss.qualcomm.com> Content-Language: en-US From: Taniya Das In-Reply-To: <20251127-sdcc_shared_floor_ops-v2-8-473afc86589c@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: XOLsW9B70wSDN2ACsBZqVYsAhpM0NgHa X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI4MDAyNiBTYWx0ZWRfXymzOAgV3FsRW a4QMjn66clzgCU4G4bvTJAAd8PxrPKFDWf1SEr+SgNh1UYUt0y0T1TFpNpInKJcqKvOR2dG4Wpv KeYHX2yEHRPeRtIu/XJ4R01M+P+9Ph55k0f7xlXi4ByBafXiXbeE0EEJt9JBvjdh7kMIDFYVxOG b/kr4lFFRJHQvrqYwFfrYxjlm071yecjONtMkRkV+nzWicBR/VG/G+AgHKSUyQqenNYs972fS72 nXj5OAoo2M/7koo8NDVoQCdUxDGvkOAaNP7ivNNV4vi88idqUOXLx3S2wD3GH+rqKZVouvBLg9a O8Hsk6/hbVPcIactRD9ZbhPyJ4Gu2cEJW3TDfcv/Zx6XojWNVNHVTGga5Cl8QIDKz+BgXKdZ8Bm K0IfzXs01p7Ip4yDbZLBjj0lqSCrGw== X-Proofpoint-ORIG-GUID: XOLsW9B70wSDN2ACsBZqVYsAhpM0NgHa X-Authority-Analysis: v=2.4 cv=MKNtWcZl c=1 sm=1 tr=0 ts=69291d3c cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=BxFOA6ydGOS16N4CFHUA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-25_02,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 malwarescore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511280026 On 11/27/2025 11:27 PM, Jagadeesh Kona wrote: > Use shared_floor_ops for the SDCC RCGs so the RCG is safely parked > during disable and the new parent configuration is programmed in > hardware only when the new parent is enabled, avoiding cases where > the RCG configuration fails to update. > > Fixes: efe504300a17 ("clk: qcom: gcc: Add support for Global Clock Controller") > Signed-off-by: Jagadeesh Kona > --- > drivers/clk/qcom/gcc-glymur.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/qcom/gcc-glymur.c b/drivers/clk/qcom/gcc-glymur.c > index deab819576d0e18afb0b699b7ec6fa4c155eb5c2..238e205735ed594618b8526651968a4f73b1104e 100644 > --- a/drivers/clk/qcom/gcc-glymur.c > +++ b/drivers/clk/qcom/gcc-glymur.c > @@ -2317,7 +2317,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src = { > .parent_data = gcc_parent_data_17, > .num_parents = ARRAY_SIZE(gcc_parent_data_17), > .flags = CLK_SET_RATE_PARENT, > - .ops = &clk_rcg2_floor_ops, > + .ops = &clk_rcg2_shared_floor_ops, > }, > }; > > @@ -2339,7 +2339,7 @@ static struct clk_rcg2 gcc_sdcc4_apps_clk_src = { > .parent_data = gcc_parent_data_3, > .num_parents = ARRAY_SIZE(gcc_parent_data_3), > .flags = CLK_SET_RATE_PARENT, > - .ops = &clk_rcg2_floor_ops, > + .ops = &clk_rcg2_shared_floor_ops, > }, > }; > > Reviewed-by: Taniya Das -- Thanks, Taniya Das