mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joel Fernandes <joelagnelf@nvidia.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"rust-for-linux@vger.kernel.org" <rust-for-linux@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	Danilo Krummrich <dakr@kernel.org>,
	David Airlie <airlied@gmail.com>
Cc: "Alexandre Courbot" <acourbot@nvidia.com>,
	"Alistair Popple" <apopple@nvidia.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"John Hubbard" <jhubbard@nvidia.com>,
	"Timur Tabi" <ttabi@nvidia.com>,
	"joel@joelfernandes.org" <joel@joelfernandes.org>,
	"Elle Rhumsaa" <elle@weathered-steel.dev>,
	"Daniel Almeida" <daniel.almeida@collabora.com>,
	"Andrea Righi" <arighi@nvidia.com>,
	"Philipp Stanner" <phasta@kernel.org>,
	"nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
	"Zhi Wang" <zhiw@nvidia.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Jani Nikula" <jani.nikula@linux.intel.com>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	"Vivi Rodrigo" <rodrigo.vivi@intel.com>,
	"Tvrtko Ursulin" <tursulin@ursulin.net>,
	"Rui Huang" <ray.huang@amd.com>,
	"Matthew Auld" <matthew.auld@intel.com>,
	"Matthew Brost" <matthew.brost@intel.com>,
	"Lucas De Marchi" <lucas.demarchi@intel.com>,
	"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	"Helge Deller" <deller@gmx.de>, "Edwin Peer" <epeer@nvidia.com>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
	"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH v4 0/3] Introduce support for C linked list interfacing and GPU Buddy bindings
Date: Thu, 4 Dec 2025 21:57:10 +0000	[thread overview]
Message-ID: <548CC7F3-4685-431F-A42B-3D8E048379A1@nvidia.com> (raw)
In-Reply-To: <20251204215129.2357292-1-joelagnelf@nvidia.com>

> On Dec 4, 2025, at 4:53 PM, Joel Fernandes <joelagnelf@nvidia.com> wrote:
> 
> This series combines a number of other series which build up to the same goal:
> to make it possible to use DRM buddy from nova-core rust code. See links to the
> different series below.
> 
> The git tree with all patches can be found at:
> git://git.kernel.org/pub/scm/linux/kernel/git/jfern/linux.git (tag: clist-buddy-v4-20251204)

FYI - this series is rebased on linux-next to reduce conflicts, but I am happy to rebase on another tree if needed/requested.

Thanks,

 - Joel





> 
> Changes for v4:
> - Combined the clist and drm buddy series:
>  - A rust module (CList) to access circular linked lists from rust code.
>  - DRM buddy allocator bindings that were originally part of RFC.
>  - DRM buddy allocator one level up to drivers/gpu/ so it can be used by
>     GPU drivers (example, nova-core) that have usecases other than DRM.
> - Add Rust bindings for the GPU buddy allocator.
> 
> Notes from past cover letters about CList:
> 
> Introduction
> ============
> This patchset introduces an interface to iterate over doubly circular linked
> lists used in the kernel (allocated by C kernel code). The main usecase is
> iterating over the list of blocks provided by the GPU buddy allocator.
> 
> The series also moves the DRM buddy allocator one level up and adds Rust
> bindings for it, enabling GPU drivers like nova-core to use it.
> 
> A question may arise: Why not use rust list.rs for this?
> =========================================================
> Rust's list.rs is used to provide safe intrusive lists for Rust-allocated
> items. In doing so, it takes ownership of the items in the list and the links
> between list items. However, the usecase for GPU buddy allocator bindings, the
> C side allocates the items in the list, and also links the list together. Due
> to this, there is an ownership conflict making list.rs not the best abstraction
> for this usecase. What we need is a view of the list, not ownership of it.
> Further, the list links in a bindings usecase may come from C allocated
> objects, not from the Rust side.
> 
> Link to v2 (clist only): https://lore.kernel.org/all/20251111171315.2196103-4-joelagnelf@nvidia.com/
> 
> Notes and patches about DRM buddy code movement and DRM buddy bindings:
> 
> Link to RFC: https://lore.kernel.org/all/20251030190613.1224287-1-joelagnelf@nvidia.com/
> Link to DRM buddy move discussion: https://lore.kernel.org/all/20251124234432.1988476-1-joelagnelf@nvidia.com/
> 
> Joel Fernandes (3):
>  rust: clist: Add support to interface with C linked lists
>  gpu: Move DRM buddy allocator one level up
>  rust: gpu: Add GPU buddy allocator bindings
> 
> Documentation/gpu/drm-mm.rst                  |   10 +-
> MAINTAINERS                                   |    7 +
> drivers/gpu/Kconfig                           |   13 +
> drivers/gpu/Makefile                          |    2 +
> drivers/gpu/buddy.c                           | 1310 +++++++++++++++++
> drivers/gpu/drm/Kconfig                       |    1 +
> drivers/gpu/drm/Kconfig.debug                 |    4 +-
> drivers/gpu/drm/amd/amdgpu/Kconfig            |    1 +
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c       |    2 +-
> .../gpu/drm/amd/amdgpu/amdgpu_res_cursor.h    |   12 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c  |   80 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.h  |   20 +-
> drivers/gpu/drm/drm_buddy.c                   | 1287 +---------------
> drivers/gpu/drm/i915/Kconfig                  |    1 +
> drivers/gpu/drm/i915/i915_scatterlist.c       |   10 +-
> drivers/gpu/drm/i915/i915_ttm_buddy_manager.c |   55 +-
> drivers/gpu/drm/i915/i915_ttm_buddy_manager.h |    6 +-
> .../drm/i915/selftests/intel_memory_region.c  |   20 +-
> drivers/gpu/drm/tests/Makefile                |    1 -
> .../gpu/drm/ttm/tests/ttm_bo_validate_test.c  |    5 +-
> drivers/gpu/drm/ttm/tests/ttm_mock_manager.c  |   18 +-
> drivers/gpu/drm/ttm/tests/ttm_mock_manager.h  |    4 +-
> drivers/gpu/drm/xe/Kconfig                    |    1 +
> drivers/gpu/drm/xe/xe_res_cursor.h            |   34 +-
> drivers/gpu/drm/xe/xe_svm.c                   |   12 +-
> drivers/gpu/drm/xe/xe_ttm_vram_mgr.c          |   73 +-
> drivers/gpu/drm/xe/xe_ttm_vram_mgr_types.h    |    4 +-
> drivers/gpu/tests/Makefile                    |    3 +
> .../gpu_buddy_test.c}                         |  390 ++---
> drivers/gpu/tests/gpu_random.c                |   48 +
> drivers/gpu/tests/gpu_random.h                |   28 +
> drivers/video/Kconfig                         |    2 +
> include/drm/drm_buddy.h                       |  163 +-
> include/linux/gpu_buddy.h                     |  177 +++
> rust/bindings/bindings_helper.h               |   11 +
> rust/helpers/gpu.c                            |   23 +
> rust/helpers/helpers.c                        |    2 +
> rust/helpers/list.c                           |   12 +
> rust/kernel/clist.rs                          |  357 +++++
> rust/kernel/gpu/buddy.rs                      |  527 +++++++
> rust/kernel/gpu/mod.rs                        |    5 +
> rust/kernel/lib.rs                            |    3 +
> 42 files changed, 2944 insertions(+), 1800 deletions(-)
> create mode 100644 drivers/gpu/Kconfig
> create mode 100644 drivers/gpu/buddy.c
> create mode 100644 drivers/gpu/tests/Makefile
> rename drivers/gpu/{drm/tests/drm_buddy_test.c => tests/gpu_buddy_test.c} (68%)
> create mode 100644 drivers/gpu/tests/gpu_random.c
> create mode 100644 drivers/gpu/tests/gpu_random.h
> create mode 100644 include/linux/gpu_buddy.h
> create mode 100644 rust/helpers/gpu.c
> create mode 100644 rust/helpers/list.c
> create mode 100644 rust/kernel/clist.rs
> create mode 100644 rust/kernel/gpu/buddy.rs
> create mode 100644 rust/kernel/gpu/mod.rs
> 
> --
> 2.34.1
> 

      parent reply	other threads:[~2025-12-04 21:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-04 21:51 Joel Fernandes
2025-12-04 21:51 ` [PATCH v4 1/3] rust: clist: Add support to interface with C linked lists Joel Fernandes
2025-12-04 21:51 ` [PATCH v4 2/3] gpu: Move DRM buddy allocator one level up Joel Fernandes
2025-12-04 21:51 ` [PATCH v4 3/3] rust: gpu: Add GPU buddy allocator bindings Joel Fernandes
2025-12-04 21:57 ` Joel Fernandes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=548CC7F3-4685-431F-A42B-3D8E048379A1@nvidia.com \
    --to=joelagnelf@nvidia.com \
    --cc=a.hindborg@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=airlied@gmail.com \
    --cc=alex.gaynor@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=aliceryhl@google.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=apopple@nvidia.com \
    --cc=arighi@nvidia.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=christian.koenig@amd.com \
    --cc=corbet@lwn.net \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=elle@weathered-steel.dev \
    --cc=epeer@nvidia.com \
    --cc=gary@garyguo.net \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=jhubbard@nvidia.com \
    --cc=joel@joelfernandes.org \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=lucas.demarchi@intel.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matthew.auld@intel.com \
    --cc=matthew.brost@intel.com \
    --cc=mripard@kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=ojeda@kernel.org \
    --cc=phasta@kernel.org \
    --cc=ray.huang@amd.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=simona@ffwll.ch \
    --cc=thomas.hellstrom@linux.intel.com \
    --cc=tmgross@umich.edu \
    --cc=ttabi@nvidia.com \
    --cc=tursulin@ursulin.net \
    --cc=tzimmermann@suse.de \
    --cc=zhiw@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®