From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79846C2D0A8 for ; Wed, 23 Sep 2020 17:16:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2846821D92 for ; Wed, 23 Sep 2020 17:16:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="i2HzfvjY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726670AbgIWRQS (ORCPT ); Wed, 23 Sep 2020 13:16:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:33942 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726620AbgIWRQR (ORCPT ); Wed, 23 Sep 2020 13:16:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600881376; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j6lyST6OFqSp3wXFZUXKiJrEGOfZYQRYSp6oi5Lyb1E=; b=i2HzfvjYtNK8Ce6s0QhEaSUPnN30+7V0O7PHdAmYJXiJMhPQeCuRI/cYN9Wwagre2kMFqr 9QEc59Ayc/mstDGOHrQJqy24yCbg1FyWJ4X5QpWTSww06669Qh0vCan6XoYGkjLf8eLzsJ 3DxyRqYFo/6NXtOoW+qKFjtyTiYtgO0= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-175-Tu294GZcN9Gmo26kfaZEMQ-1; Wed, 23 Sep 2020 13:16:14 -0400 X-MC-Unique: Tu294GZcN9Gmo26kfaZEMQ-1 Received: by mail-wr1-f71.google.com with SMTP id l17so98812wrw.11 for ; Wed, 23 Sep 2020 10:16:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=j6lyST6OFqSp3wXFZUXKiJrEGOfZYQRYSp6oi5Lyb1E=; b=q6FttCwOxGeaj1vricC2oG2rXQsAkpVBSB07gRtzThLAV7v0m4Rrz3727U+Jd+dVuC /1AWj+eGk1eZMuKMCTSw2f1Nj5uF22P7feAEzwNzrQjeflzPl90BmpjGLISGsNBqOKAR p7Z1YnfzAmMKfcrJipnAWZojOhu4ORf7sT9T6XOLsdO/anGLzA568Ppu6pGqcWXEt2Ks urNf/TOmvWe6Wj708thFkUdzIatc4oBxMLXuhcGAycLX8bVIIdtx1WlBWdeLenII8Av8 Rb8x0Syt6tKBvgKkhVfsiRQZznSUk+lzO9HwpHc0kCIesFGR3iucdsad79VFPG6/WTbR T4ug== X-Gm-Message-State: AOAM531dkYWKqFB92U1+MrjEhjptYhpO1t3zruHFvE0LBd8Rj39W8w+o YCUkN43zFM7YD5NFmJvY/Apf5O8VM3meto2lRPo5kTgC8os8kdoh5d3eq9Y5Jgy+ELvoJk02AJW ehoML3qfFF2rRU8/Xg9sot40i X-Received: by 2002:a1c:dd45:: with SMTP id u66mr547602wmg.117.1600881371872; Wed, 23 Sep 2020 10:16:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwBQZUkAml+/LYsKte8cnjwy8zg/1tkQYiaknmCWyZZ4jYwsCvCbzOMxy5MpbTqXnEspn1mFA== X-Received: by 2002:a1c:dd45:: with SMTP id u66mr547580wmg.117.1600881371683; Wed, 23 Sep 2020 10:16:11 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:15f1:648d:7de6:bad9? ([2001:b07:6468:f312:15f1:648d:7de6:bad9]) by smtp.gmail.com with ESMTPSA id e18sm439361wrx.50.2020.09.23.10.16.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Sep 2020 10:16:10 -0700 (PDT) Subject: Re: [PATCH] KVM: SVM: Mark SEV launch secret pages as dirty. To: Sean Christopherson Cc: Cfir Cohen , "kvm @ vger . kernel . org" , Lendacky Thomas , Singh Brijesh , Grimm Jon , David Rientjes , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org References: <20200807012303.3769170-1-cfir@google.com> <20200919045505.GC21189@sjchrist-ice> <5ac77c46-88b4-df45-4f02-72adfb096262@redhat.com> <20200923170444.GA20076@linux.intel.com> From: Paolo Bonzini Message-ID: <548b7b73-7a13-8267-414e-2b9e1569c7f7@redhat.com> Date: Wed, 23 Sep 2020 19:16:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200923170444.GA20076@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/09/20 19:04, Sean Christopherson wrote: >> Two of the three instances are a bit different though. What about this >> which at least shortens the comment to 2 fewer lines: > Any objection to changing those to "Flush (on non-coherent CPUs)"? I agree > it would be helpful to call out the details, especially for DBG_*, but I > don't like that it reads as if the flush is unconditional. Hmm... It's already fairly long lines so that would wrap to 3 lines, and the reference to the conditional flush wasn't there before either. sev_clflush_pages could be a better place to mention that (or perhaps it's self-explanatory). Paolo