mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: zhangfei <zhangfei.gao@linaro.org>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: kbuild-all@01.org, Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	"xuwei (O)" <xuwei5@hisilicon.com>
Subject: Re: [PATCH hisi] Input: i2c_atmel_read() can be static
Date: Sun, 21 Dec 2014 19:29:45 +0800	[thread overview]
Message-ID: <5496AF29.3060802@linaro.org> (raw)
In-Reply-To: <20141219015659.GA49367@snb.sh.intel.com>



On 12/19/2014 09:56 AM, kbuild test robot wrote:
> drivers/input/touchscreen/atmel_mXT224E.c:460:5: sparse: symbol 'i2c_atmel_read' was not declared. Should it be static?
> drivers/input/touchscreen/atmel_mXT224E.c:496:5: sparse: symbol 'i2c_atmel_write' was not declared. Should it be static?
> drivers/input/touchscreen/atmel_mXT224E.c:532:5: sparse: symbol 'i2c_atmel_write_byte_data' was not declared. Should it be static?
> drivers/input/touchscreen/atmel_mXT224E.c:538:10: sparse: symbol 'get_object_address' was not declared. Should it be static?
> drivers/input/touchscreen/atmel_mXT224E.c:547:9: sparse: symbol 'get_object_size' was not declared. Should it be static?
> drivers/input/touchscreen/atmel_mXT224E.c:557:9: sparse: symbol 'get_object_size_from_address' was not declared. Should it be static?
> drivers/input/touchscreen/atmel_mXT224E.c:847:32: sparse: symbol 'atmel_ts_get_pdata' was not declared. Should it be static?
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Thanks Fengguang for the patch, will take it.

However, the file drivers/input/touchscreen/atmel_mXT224E.c is not used 
for mainline kernel.

Xuwei will remove git://github.com/hisilicon/linux-hisi 
integration-hilt-linux-linaro.
Sorry for the confusion.

Thanks

      reply	other threads:[~2014-12-21 11:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-19  1:56 [hisi:integration-hilt-linux-linaro 17/28] drivers/input/touchscreen/atmel_mXT224E.c:460:5: sparse: symbol 'i2c_atmel_read' was not declared. Should it be static? kbuild test robot
2014-12-19  1:56 ` [PATCH hisi] Input: i2c_atmel_read() can be static kbuild test robot
2014-12-21 11:29   ` zhangfei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5496AF29.3060802@linaro.org \
    --to=zhangfei.gao@linaro.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=fengguang.wu@intel.com \
    --cc=kbuild-all@01.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xuwei5@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome