From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754013Ab2GaOCQ (ORCPT ); Tue, 31 Jul 2012 10:02:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53352 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753890Ab2GaOCP (ORCPT ); Tue, 31 Jul 2012 10:02:15 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20120731130314.24441.85882.stgit@ltc137.sdl.hitachi.co.jp> References: <20120731130314.24441.85882.stgit@ltc137.sdl.hitachi.co.jp> To: Mitsuo Hayasaka Cc: dhowells@redhat.com, "Eric W. Biederman" , Andrew Morton , James Morris , linux-kernel@vger.kernel.org, yrl.pp-manager.tt@hitachi.com Subject: Re: [PATCH] sysctl: fix improper indication of integer sysctl parameter Date: Tue, 31 Jul 2012 15:02:05 +0100 Message-ID: <5498.1343743325@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mitsuo Hayasaka wrote: > When we read the sysctl parameter, they are always treated > as signed integer, and are casted into unsigned long type > in the current kernel. If we set a value equivalent to > (the maximum value in signed integer + 1) Wouldn't it be better to return EINVAL or EDOM? David