From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753732AbcHZTs5 (ORCPT ); Fri, 26 Aug 2016 15:48:57 -0400 Received: from mga11.intel.com ([192.55.52.93]:45339 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751139AbcHZTs4 (ORCPT ); Fri, 26 Aug 2016 15:48:56 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,582,1464678000"; d="scan'208";a="871519202" Subject: Re: [PATCH] staging/lustre: avoid zero buf for the first time Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=us-ascii From: Oleg Drokin In-Reply-To: <20160822100408.GA11890@kroah.com> Date: Fri, 26 Aug 2016 15:48:27 -0400 Cc: Shawn Lin , Andreas Dilger , , , Content-Transfer-Encoding: 7bit Message-Id: <5498CEC3-3AB9-487B-9899-3E9372D2C575@intel.com> References: <1471855564-15962-1-git-send-email-shawn.lin@rock-chips.com> <20160822100408.GA11890@kroah.com> To: Greg Kroah-Hartman X-Mailer: Apple Mail (2.1283) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! On Aug 22, 2016, at 6:04 AM, Greg Kroah-Hartman wrote: > On Mon, Aug 22, 2016 at 04:46:04PM +0800, Shawn Lin wrote: >> We only need to zero it when repeating in order to >> avoid old garbage. Let's improve it by moving this >> before we repeat the calculation to save some cpu >> cycle. >> >> Signed-off-by: Shawn Lin > > Have you noticed a change with this in a benchmark? > > If not, is it really worth it? The other problem is we would need to remember to memset it should there be more paths jumping to the repeat label which might be easy to miss, so we are probably better off without this patch. > I need an ack from the lustre developers before taking patches like > this... > > thanks, > > greg k-h