From: Corey Minyard <minyard@acm.org>
To: nick <xerofoify@gmail.com>
Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: Question about the function,ipmi_release in ipmi_devinf.c
Date: Tue, 23 Dec 2014 08:13:09 -0600 [thread overview]
Message-ID: <54997875.5070607@acm.org> (raw)
In-Reply-To: <54974BAA.9020107@gmail.com>
On 12/21/2014 04:37 PM, nick wrote:
> Greetings Again Corney,
> Hope you are looking forward to the holidays. I am one question, about the function in my message.
> /* FIXME - free the messages in the list. */, is in this function I am wondering is this needed?
> Further more the only reason I can see for it is if we are to free the linked list of files or
> inodes passed to the function, otherwise it's invalid. Please let me known if should sent in
> a patch to remove it or add a for_each_through linked list call that deletes each file or inode
> in the list passed.
The recv_msgs list needs to be cleaned up in this case. Basically, just
call ipmi_free_recv_msg()
on every message in the list. A patch would be appreciated.
Thanks,
-corey
parent reply other threads:[~2014-12-23 14:13 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <54974BAA.9020107@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54997875.5070607@acm.org \
--to=minyard@acm.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome