mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>
To: "vulab@iscas.ac.cn" <vulab@iscas.ac.cn>,
	"idryomov@gmail.com" <idryomov@gmail.com>,
	"slava@dubeyko.com" <slava@dubeyko.com>,
	Alex Markuze <amarkuze@redhat.com>
Cc: "ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re:  [PATCH] ceph: fix writeback_count leak in write_folio_nounlock()
Date: Thu, 28 May 2026 18:44:14 +0000	[thread overview]
Message-ID: <549d1a995cdba258425126d2826dcd2601e9463f.camel@ibm.com> (raw)
In-Reply-To: <20260528035458.1146314-1-vulab@iscas.ac.cn>

On Thu, 2026-05-28 at 03:54 +0000, Wentao Liang wrote:
> write_folio_nounlock() increments fsc->writeback_count to track
> in-flight writeback operations. On several error paths where the
> function returns early (folio lookup failure, snapshot context
> allocation failure, and writepages submission failure), the function
> returns without calling atomic_long_dec() to decrement the counter.
> 
> Each leaked increment keeps the counter above zero, which can prevent
> the filesystem from cleanly unmounting or suspending writes.
> 
> Add atomic_long_dec() calls on all error paths that currently return
> without decrementing the counter.
> 
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---
>  fs/ceph/addr.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
> index 0a86f672cc09..a606378649c3 100644
> --- a/fs/ceph/addr.c
> +++ b/fs/ceph/addr.c
> @@ -790,6 +790,7 @@ static int write_folio_nounlock(struct folio *folio,
>  				    ceph_wbc.truncate_size, true);
>  	if (IS_ERR(req)) {
>  		folio_redirty_for_writepage(wbc, folio);
> +		atomic_long_dec(&fsc->writeback_count);

Good catch. But I believe that we need to use this pattern in all three cases:

  if (atomic_long_dec_return(&fsc->writeback_count) <
      CONGESTION_OFF_THRESH(fsc->mount_options->congestion_kb))
      fsc->write_congested = false;

>  		return PTR_ERR(req);
>  	}
>  
> @@ -809,6 +810,7 @@ static int write_folio_nounlock(struct folio *folio,
>  			folio_redirty_for_writepage(wbc, folio);
>  			folio_end_writeback(folio);
>  			ceph_osdc_put_request(req);
> +			atomic_long_dec(&fsc->writeback_count);

Ditto.

>  			return PTR_ERR(bounce_page);
>  		}
>  	}
> @@ -847,6 +849,7 @@ static int write_folio_nounlock(struct folio *folio,
>  			      ceph_vinop(inode), folio);
>  			folio_redirty_for_writepage(wbc, folio);
>  			folio_end_writeback(folio);
> +			atomic_long_dec_return(&fsc->writeback_count);

Ditto. Especially, it is not clear why atomic_long_dec_return() was used instead
of atomic_long_dec() if we don't follow the above-mentioned pattern.

Thanks,
Slava.

>  			return err;
>  		}
>  		if (err == -EBLOCKLISTED)

      reply	other threads:[~2026-05-28 18:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-28  3:54 Wentao Liang
2026-05-28 18:44 ` Viacheslav Dubeyko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=549d1a995cdba258425126d2826dcd2601e9463f.camel@ibm.com \
    --to=slava.dubeyko@ibm.com \
    --cc=amarkuze@redhat.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=idryomov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=slava@dubeyko.com \
    --cc=vulab@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®