From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752094AbbABQkJ (ORCPT ); Fri, 2 Jan 2015 11:40:09 -0500 Received: from mail-ob0-f176.google.com ([209.85.214.176]:48915 "EHLO mail-ob0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750717AbbABQkH (ORCPT ); Fri, 2 Jan 2015 11:40:07 -0500 Message-ID: <54A6C9E4.80009@lwfinger.net> Date: Fri, 02 Jan 2015 10:40:04 -0600 From: Larry Finger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Nicholas Krause , stefano.brivio@polimi.it CC: netdev@vger.kernel.org, linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, kvalo@codeaurora.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers:net:wireless: Add proper locking for the function, b43_op_beacon_set_tim in main.c References: <1420184041-6788-1-git-send-email-xerofoify@gmail.com> In-Reply-To: <1420184041-6788-1-git-send-email-xerofoify@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/02/2015 01:34 AM, Nicholas Krause wrote: > This adds proper locking for the function, b43_op_beacon_set_tim in main.c by using the mutex lock > in the structure pointer wl, as embedded into this pointer as a mutex in order to protect against > multiple access to the pointer wl when updating the templates for this pointer in the function, > b43_update_templates internally in the function, b43_op_beacon_set_tim. > > Signed-off-by: Nicholas Krause Although this patch has already been rejected, I want to comment on the subject you have chosen. As you are submitting it to the maintainer of drivers/net/wireless/, there is no need to place those entities in the subject. A better subject would have been "b43: Add proper locking for b43_op_beacon_set_tim()". Larry