From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756594AbbAIVe2 (ORCPT ); Fri, 9 Jan 2015 16:34:28 -0500 Received: from mail-wi0-f177.google.com ([209.85.212.177]:49796 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750772AbbAIVe0 (ORCPT ); Fri, 9 Jan 2015 16:34:26 -0500 Message-ID: <54B048E4.3080102@vanguardiasur.com.ar> Date: Fri, 09 Jan 2015 18:32:20 -0300 From: Ezequiel Garcia Organization: VanguardiaSur User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Richard Weinberger , dedekind1@gmail.com CC: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] UBI: Fastmap: Ensure that all fastmap work is done upon WL shutdown References: <1416835236-25185-1-git-send-email-richard@nod.at> <1416835236-25185-4-git-send-email-richard@nod.at> In-Reply-To: <1416835236-25185-4-git-send-email-richard@nod.at> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/24/2014 10:20 AM, Richard Weinberger wrote: > ...otherwise the deferred work might run after datastructures > got freed and corrupt memory. > > Signed-off-by: Richard Weinberger > --- > drivers/mtd/ubi/wl.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c > index 7f135df..cb2e571 100644 > --- a/drivers/mtd/ubi/wl.c > +++ b/drivers/mtd/ubi/wl.c > @@ -2041,6 +2041,9 @@ static void protection_queue_destroy(struct ubi_device *ubi) > void ubi_wl_close(struct ubi_device *ubi) > { > dbg_wl("close the WL sub-system"); > +#ifdef CONFIG_MTD_UBI_FASTMAP > + flush_work(&ubi->fm_work); > +#endif > shutdown_work(ubi); > protection_queue_destroy(ubi); > tree_destroy(&ubi->used); > IMHO, it's best to avoid nasty ifdefs like this (there are lots of ways of getting it cleaner). But I guess it's not a big deal. -- Ezequiel Garcia, VanguardiaSur www.vanguardiasur.com.ar