From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
To: Richard Weinberger <richard@nod.at>, dedekind1@gmail.com
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: Fastmap update v2 (pile 1)
Date: Fri, 09 Jan 2015 19:09:55 -0300 [thread overview]
Message-ID: <54B051B3.3050308@vanguardiasur.com.ar> (raw)
In-Reply-To: <54B04E65.60306@nod.at>
On 01/09/2015 06:55 PM, Richard Weinberger wrote:
> Am 09.01.2015 um 22:38 schrieb Ezequiel Garcia:
>> Hi Richard,
>>
>> On 11/24/2014 10:20 AM, Richard Weinberger wrote:
>>> Artem,
>>>
>>> as requested I'm resending my fastmap work in smaller pieces.
>>> This is pile 1 of 7.
>>> Rebasing my patches to ubifs.git was a massive PITA because the
>>> logging style changes touched a lot of code and almost every patch
>>> failed to apply and needed inspection by hand.
>>> The first patches are bug fixes, the latter introduce cleanups
>>> and new features.
>>> After all bugfixes are mainline I'll make sure that all needed
>>> fixes go into -stable.
>>>
>>
>> Maybe it would be clearer if you could point out exactly which of these
>> are considered bugfixes.
>
> All of Pile1, 2, 3 and 4. :-)
> One or tow patches are preparations for the real fix but obviously you'll need them
> too.
> The rest are enhancements and cleanups.
What do you mean by "the rest"?
> As I wrote before I've structured the patch set in a way to make backporting easy.
>
>> For bugfixes, having a detailed explanation of the problem the commit is
>> meant to fix would be better as well.
>
> Okay, I'll add the horror stories to these patches.
>
I know it's a real pain, but if you can add a Fixes: tag, it would
certainly help Artem track down the bug. The good thing is that you get
the -stable hassle for free.
>> This patchset seems to have stalled, so perhaps having this information
>> would help Artem to pick the ones that you point as fixes, before we
>> miss another cycle.
>
> The question is, shall I wait for Artem or resend again?
Hm, well, given we are just a handful of developers, and we are all time
constrained, maybe we could focus on the first two piles for now:
Pile 1, November 24, https://lkml.org/lkml/2014/11/24/324
Pile 2, November 30, https://lkml.org/lkml/2014/11/30/50
> Most patches are completely unseen.
>
Well, those two piles look reviewed and tested to me.
--
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar
next prev parent reply other threads:[~2015-01-09 22:12 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 13:20 Richard Weinberger
2014-11-24 13:20 ` [PATCH 1/6] UBI: Fastmap: Care about the protection queue Richard Weinberger
2014-11-27 14:54 ` Artem Bityutskiy
2015-01-09 21:23 ` Ezequiel Garcia
2015-01-09 21:31 ` Richard Weinberger
2015-01-09 21:34 ` Ezequiel Garcia
2014-11-24 13:20 ` [PATCH 2/6] UBI: Fastmap: Ensure that only one fastmap work is scheduled Richard Weinberger
2014-11-27 15:27 ` Artem Bityutskiy
2014-11-27 16:13 ` Richard Weinberger
2014-11-27 16:35 ` Artem Bityutskiy
2014-11-27 16:39 ` Richard Weinberger
2014-11-27 16:49 ` Artem Bityutskiy
2014-12-04 16:14 ` Tanya Brokhman
2014-12-17 13:51 ` Guido Martínez
2014-11-24 13:20 ` [PATCH 3/6] UBI: Fastmap: Ensure that all fastmap work is done upon WL shutdown Richard Weinberger
2014-11-27 15:38 ` Artem Bityutskiy
2014-11-27 16:08 ` Richard Weinberger
2014-11-27 16:29 ` Artem Bityutskiy
2014-11-27 16:35 ` Richard Weinberger
2014-11-27 16:47 ` Artem Bityutskiy
2014-11-28 9:53 ` Richard Weinberger
2014-12-04 16:44 ` Tanya Brokhman
2014-12-04 17:21 ` Richard Weinberger
2014-12-17 14:26 ` Guido Martínez
2015-01-09 21:32 ` Ezequiel Garcia
2015-01-09 21:37 ` Richard Weinberger
2015-01-09 21:39 ` Ezequiel Garcia
2014-11-24 13:20 ` [PATCH 4/6] UBI: Fastmap: Fix races in ubi_wl_get_peb() Richard Weinberger
2014-12-05 13:09 ` Tanya Brokhman
2014-12-05 13:20 ` Richard Weinberger
2014-12-05 16:54 ` Tanya Brokhman
2014-12-05 21:08 ` Richard Weinberger
2014-12-07 7:36 ` Tanya Brokhman
2014-12-07 9:45 ` Richard Weinberger
2014-11-24 13:20 ` [PATCH 5/6] UBI: Split __wl_get_peb() Richard Weinberger
2014-12-05 17:41 ` Tanya Brokhman
2014-12-05 21:02 ` Richard Weinberger
2014-12-17 15:03 ` Guido Martínez
2014-11-24 13:20 ` [PATCH 6/6] UBI: Fastmap: Make ubi_refill_pools() fair Richard Weinberger
2014-12-05 17:55 ` Tanya Brokhman
2014-12-05 20:56 ` Richard Weinberger
2014-12-07 7:55 ` Tanya Brokhman
2014-12-07 9:49 ` Richard Weinberger
2014-12-17 15:48 ` Guido Martínez
2014-11-27 14:53 ` Fastmap update v2 (pile 1) Artem Bityutskiy
2014-11-27 14:59 ` Richard Weinberger
2014-12-10 8:21 ` Richard Weinberger
2015-01-05 10:37 ` Richard Weinberger
2015-01-09 21:38 ` Ezequiel Garcia
2015-01-09 21:55 ` Richard Weinberger
2015-01-09 22:09 ` Ezequiel Garcia [this message]
2015-01-09 22:20 ` Richard Weinberger
2015-03-29 10:46 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B051B3.3050308@vanguardiasur.com.ar \
--to=ezequiel@vanguardiasur.com.ar \
--cc=dedekind1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®