From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752126AbbAKVKL (ORCPT ); Sun, 11 Jan 2015 16:10:11 -0500 Received: from nupi.pair.com ([209.68.5.149]:29588 "EHLO nupi.pair.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751361AbbAKVKI (ORCPT ); Sun, 11 Jan 2015 16:10:08 -0500 Message-ID: <54B2E6AF.8060501@flaterco.com> Date: Sun, 11 Jan 2015 16:10:07 -0500 From: David Flater User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Takashi Iwai CC: Jaroslav Kysela , LKML , Alsa Devel Subject: [PATCHv3 2/2] ALSA: log emu8000 DRAM size at level INFO Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applicable after PATCHv3 1/2: Detected sound font memory goes unreported unless the kernel was built with ALSA debugging enabled. Elevate that to a pr_info. Signed-off-by: David Flater --- History: 2015-01-11 v3: In response to feedback from Takashi Iwai, Patch 1: Repeat code to avoid goto middle of loop. Patch 2: Use pr_info not printk. Retested on CT4390 (4 MiB) and CT4380 (512 KiB). 2015-01-09 v2: In response to feedback from Takashi Iwai, 1. Optimize for diff size. 1a. Use goto to avoid indenting and repeating code. 1b. Jettison new debugging printouts. 2. Split printk into second patch. Retested on CT4390 (4 MiB) and CT4380 (512 KiB). 2015-01-08 v1 patch sent to LKML, Alsa Devel and maintainers. Tested on unexpanded CT4390 (4 MiB), CT4520 (512 KiB), and CT4380 (512 KiB). sound/isa/sb/emu8000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/isa/sb/emu8000.c b/sound/isa/sb/emu8000.c index d25e384..96e9d94 100644 --- a/sound/isa/sb/emu8000.c +++ b/sound/isa/sb/emu8000.c @@ -453,7 +453,7 @@ skip_detect: snd_emu8000_dma_chan(emu, 0, EMU8000_RAM_CLOSE); snd_emu8000_dma_chan(emu, 1, EMU8000_RAM_CLOSE); - snd_printdd("EMU8000 [0x%lx]: %d Kb on-board memory detected\n", + pr_info("EMU8000 [0x%lx]: %d KiB on-board DRAM detected\n", emu->port1, size/1024); emu->mem_size = size; -- 1.8.4