Re: [PATCH] x86: kvm: vmx: Remove some unused functions

[Paolo Bonzini <pbonzini@redhat.com>]

On 11/01/2015 19:02, Rickard Strandqvist wrote:
> Removes some functions that are not used anywhere:
> cpu_has_vmx_eptp_writeback() cpu_has_vmx_eptp_uncacheable()
> 
> This was partially found by using a static code analysis program called cppcheck.
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
>  arch/x86/kvm/vmx.c |   10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 3e556c6..e273f15 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -951,16 +951,6 @@ static inline bool cpu_has_vmx_ept_execute_only(void)
>  	return vmx_capability.ept & VMX_EPT_EXECUTE_ONLY_BIT;
>  }
>  
> -static inline bool cpu_has_vmx_eptp_uncacheable(void)
> -{
> -	return vmx_capability.ept & VMX_EPTP_UC_BIT;
> -}
> -
> -static inline bool cpu_has_vmx_eptp_writeback(void)
> -{
> -	return vmx_capability.ept & VMX_EPTP_WB_BIT;
> -}
> -
>  static inline bool cpu_has_vmx_ept_2m_page(void)
>  {
>  	return vmx_capability.ept & VMX_EPT_2MB_PAGE_BIT;
> 

Looks good, thanks.

Paolo