From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755557AbbAZKQg (ORCPT ); Mon, 26 Jan 2015 05:16:36 -0500 Received: from mail.linn.co.uk ([195.59.102.251]:61953 "EHLO mail.linn.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755533AbbAZKQc (ORCPT ); Mon, 26 Jan 2015 05:16:32 -0500 Message-ID: <54C613F2.5090507@linn.co.uk> Date: Mon, 26 Jan 2015 10:16:18 +0000 From: Stathis Voukelatos User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Mark Rutland , Stathis Voukelatos CC: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "abrestic@chromium.org" Subject: Re: [PATCH] net: Linn Ethernet Packet Sniffer driver References: <1422007621-13567-1-git-send-email-stathis.voukelatos@linn.co.uk> <20150123105114.GB23493@leverpostej> In-Reply-To: <20150123105114.GB23493@leverpostej> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.2.10.219] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/01/15 10:51, Mark Rutland wrote: > > diff --git a/Documentation/devicetree/bindings/net/linn-ether-packet-sniffer.txt b/Documentation/devicetree/bindings/net/linn-ether-packet-sniffer.txt > new file mode 100644 > index 0000000..6b6e105 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/linn-ether-packet-sniffer.txt > @@ -0,0 +1,27 @@ > +* Linn Products Ethernet Packet Sniffer > + > +Required properties: > +- compatible : must be "linn,eth-sniffer" > +- reg : physical addresses and sizes of registers. Must contain 3 entries: > + first entry: registers memory space > + second entry: TX command memory > + third entry: RX command memory > Just to check: are those memories are part of the packet sniffer device, > or are carveouts from other memory? Yes, the 3 memory areas are part of the packet sniffer module. >> +- fifo-block-words : number of words in one data FIFO entry >> + >> +Example: >> + >> +sniffer@1814a000 { >> + compatible = "linn,eth-sniffer"; >> + reg = <0x1814a000 0x100>, <0x1814a400 0x400>, <0x1814a800 0x400>; >> + reg-names = "regs", "tx-ram", "rx-ram"; >> + interrupts = ; >> + interrupt-names = "eth-sniffer-irq"; >> + clocks = <&system_clk>; >> + clock-names = "sys"; >> + fifo-block-words = <4>; >> + }; > Surely the relationship between the sniffer, MAC, and PHY should be > described, so we know which interface the sniffer is related to? > The packet sniffer sits between the MAC and the PHY and monitors TX or RX packets, or both. Will add a description in the binding doc. Your other suggestions too, will be incorporated in the next version of the patch set. Thank you, Stathis