From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Peter Hung <hpeter@gmail.com>, johan@kernel.org
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, tom_tsai@fintek.com.tw,
peter_hong@fintek.com.tw,
Peter Hung <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH v3 5/5] usb: serial: implement CMSPAR for F81232
Date: Thu, 29 Jan 2015 13:25:26 +0300 [thread overview]
Message-ID: <54CA0A96.1090007@cogentembedded.com> (raw)
In-Reply-To: <54C9946D.508@gmail.com>
Hello.
On 1/29/2015 5:01 AM, Peter Hung wrote:
> Hello.
Please don't top-post.
> I had using "scripts/checkpatch.pl -f" to scan original f81232.c.
> It reported with "quoted string split across lines", so I merge these
> 2 strings into 1 in patch 1/5.
Seems like another unrelated change...
> But it still warning with "line over 80
> character", so I had shorted string with this line.
Hm, the modern checkpatch.pl shouldn't warn about long lines due to string
literals used in dev_err(), etc. calls.
> I will refine my patch set again with more attention.
In any case, don't leave the warnings till some next patch, fix them at once.
> Thanks for your advice.
WBR, Sergei
prev parent reply other threads:[~2015-01-29 10:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 5:58 Peter Hung
2015-01-28 12:31 ` Sergei Shtylyov
2015-01-29 2:01 ` Peter Hung
2015-01-29 10:25 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CA0A96.1090007@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpeter+linux_kernel@gmail.com \
--cc=hpeter@gmail.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter_hong@fintek.com.tw \
--cc=tom_tsai@fintek.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome