From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755506AbbA2MwT (ORCPT ); Thu, 29 Jan 2015 07:52:19 -0500 Received: from smtp113.iad3a.emailsrvr.com ([173.203.187.113]:50592 "EHLO smtp113.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753049AbbA2MwS (ORCPT ); Thu, 29 Jan 2015 07:52:18 -0500 X-Sender-Id: abbotti@mev.co.uk Message-ID: <54CA2CFF.7080203@mev.co.uk> Date: Thu, 29 Jan 2015 12:52:15 +0000 From: Ian Abbott User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0 MIME-Version: 1.0 To: Rickard Strandqvist , H Hartley Sweeten CC: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: comedi: drivers: dt2814: Removed variables that is never used References: <1422484430-8686-1-git-send-email-rickard_strandqvist@spectrumdigital.se> In-Reply-To: <1422484430-8686-1-git-send-email-rickard_strandqvist@spectrumdigital.se> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/01/15 22:33, Rickard Strandqvist wrote: > Variable ar assigned a value that is never used. > I have also removed all the code that thereby serves no purpose. > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist > --- > drivers/staging/comedi/drivers/dt2814.c | 13 ++++--------- > 1 file changed, 4 insertions(+), 9 deletions(-) Good, apart from the bad English! Reviewed-by: Ian Abbott -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-