From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760562AbbA3KdR (ORCPT ); Fri, 30 Jan 2015 05:33:17 -0500 Received: from smtp73.iad3a.emailsrvr.com ([173.203.187.73]:58962 "EHLO smtp73.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755825AbbA3KdP (ORCPT ); Fri, 30 Jan 2015 05:33:15 -0500 X-Sender-Id: abbotti@mev.co.uk Message-ID: <54CB5DE8.1080008@mev.co.uk> Date: Fri, 30 Jan 2015 10:33:12 +0000 From: Ian Abbott User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0 MIME-Version: 1.0 To: Rickard Strandqvist , H Hartley Sweeten CC: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: comedi: drivers: dyna_pci10xx: Removed variables that is never used References: <1422571208-10041-1-git-send-email-rickard_strandqvist@spectrumdigital.se> In-Reply-To: <1422571208-10041-1-git-send-email-rickard_strandqvist@spectrumdigital.se> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/01/15 22:40, Rickard Strandqvist wrote: > Variable was assigned a value that was never used. > I have also removed all the code that thereby serves no purpose. > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist > --- > drivers/staging/comedi/drivers/dyna_pci10xx.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/dyna_pci10xx.c b/drivers/staging/comedi/drivers/dyna_pci10xx.c > index 1b6324c..56490f4 100644 > --- a/drivers/staging/comedi/drivers/dyna_pci10xx.c > +++ b/drivers/staging/comedi/drivers/dyna_pci10xx.c > @@ -1,4 +1,4 @@ > -/* > +_/* Something went wrong there. :) > * comedi/drivers/dyna_pci10xx.c > * Copyright (C) 2011 Prashant Shah, pshah.mumbai@gmail.com > * > @@ -115,10 +115,6 @@ static int dyna_pci10xx_insn_write_ao(struct comedi_device *dev, > { > struct dyna_pci10xx_private *devpriv = dev->private; > int n; > - unsigned int chan, range; > - > - chan = CR_CHAN(insn->chanspec); > - range = range_codes_pci1050_ai[CR_RANGE((insn->chanspec))]; > > mutex_lock(&devpriv->mutex); > for (n = 0; n < insn->n; n++) { > That part is good. -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-