From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761480AbbA3LTn (ORCPT ); Fri, 30 Jan 2015 06:19:43 -0500 Received: from jabba.london.02.net ([82.132.130.169]:59575 "EHLO mail.o2.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1760563AbbA3LTm (ORCPT ); Fri, 30 Jan 2015 06:19:42 -0500 Message-ID: <54CB68C1.3000503@berndporr.me.uk> Date: Fri, 30 Jan 2015 11:19:29 +0000 From: Bernd Porr User-Agent: Thunderbird 2.0.0.24 (X11/20100228) MIME-Version: 1.0 To: Ian Abbott CC: Rickard Strandqvist , H Hartley Sweeten , Greg Kroah-Hartman , Chase Southwood , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: comedi: drivers: usbduxsigma: Removed variables that is never used References: <1422571809-11476-1-git-send-email-rickard_strandqvist@spectrumdigital.se> <54CB6253.5080906@mev.co.uk> In-Reply-To: <54CB6253.5080906@mev.co.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ian Abbott wrote: > On 29/01/15 22:50, Rickard Strandqvist wrote: >> Variable was assigned a value that was never used. >> I have also removed all the code that thereby serves no purpose. >> >> This was found using a static code analysis program called cppcheck >> >> Signed-off-by: Rickard Strandqvist >> >> --- >> drivers/staging/comedi/drivers/usbduxsigma.c | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/drivers/staging/comedi/drivers/usbduxsigma.c >> b/drivers/staging/comedi/drivers/usbduxsigma.c >> index dc19435..185f2d1 100644 >> --- a/drivers/staging/comedi/drivers/usbduxsigma.c >> +++ b/drivers/staging/comedi/drivers/usbduxsigma.c >> @@ -215,7 +215,6 @@ static void usbduxsigma_ai_handle_urb(struct >> comedi_device *dev, >> struct usbduxsigma_private *devpriv = dev->private; >> struct comedi_async *async = s->async; >> struct comedi_cmd *cmd = &async->cmd; >> - unsigned int dio_state; >> uint32_t val; >> int ret; >> int i; >> @@ -224,9 +223,6 @@ static void usbduxsigma_ai_handle_urb(struct >> comedi_device *dev, >> if (devpriv->ai_counter == 0) { >> devpriv->ai_counter = devpriv->ai_timer; >> >> - /* get the state of the dio pins to allow external trigger */ >> - dio_state = be32_to_cpu(devpriv->in_buf[0]); >> - >> /* get the data from the USB bus and hand it over to comedi */ >> for (i = 0; i < cmd->chanlist_len; i++) { >> /* transfer data, note first byte is the DIO state */ >> > > Reviewed-by: Ian Abbott > Reviewed-by: Bernd Porr