From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754549AbbAaLSq (ORCPT ); Sat, 31 Jan 2015 06:18:46 -0500 Received: from regular1.263xmail.com ([211.150.99.138]:53651 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754132AbbAaLSo (ORCPT ); Sat, 31 Jan 2015 06:18:44 -0500 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:S;ATT:S;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-MAE-MAIL_UID: 0054ccba100ad7b9@maes@716bebd6060a6fab X-MAE-ID: 223.6.254.61 X-RL-NAME: X-LOGIN-NAME: X-SENDER-IP: 121.15.173.1 Message-ID: <54CCBA06.8080507@rock-chips.com> Date: Sat, 31 Jan 2015 06:18:30 -0500 From: Yang Kuankuan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Russell King - ARM Linux CC: David Airlie , Philipp Zabel , Fabio Estevam , Shawn Guo , Rob Clark , Mark Yao , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, djkurtz@chromium.org, dbehr@chromoum.org, mmind00@googlemail.com, dianders@chromium.org, marcheu@chromium.org, rockchip-discuss@chromium.org Subject: Re: [PATCH v2 03/12] drm: bridge/dw_hdmi: add irq control to suspend/resume References: <1422617031-25098-1-git-send-email-ykk@rock-chips.com> <1422617280-25363-1-git-send-email-ykk@rock-chips.com> <20150131111157.GW26493@n2100.arm.linux.org.uk> In-Reply-To: <20150131111157.GW26493@n2100.arm.linux.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/31/2015 06:11 AM, Russell King - ARM Linux wrote: > On Fri, Jan 30, 2015 at 06:28:00AM -0500, Yakir Yang wrote: >> diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c >> index 2ded957..13f26af 100644 >> --- a/drivers/gpu/drm/bridge/dw_hdmi.c >> +++ b/drivers/gpu/drm/bridge/dw_hdmi.c >> @@ -1745,6 +1745,49 @@ void dw_hdmi_unbind(struct device *dev, struct device *master, void *data) >> } >> EXPORT_SYMBOL_GPL(dw_hdmi_unbind); >> >> +int dw_hdmi_suspend(struct platform_device *pdev, pm_message_t state) >> +{ > ... >> +int dw_hdmi_resume(struct platform_device *pdev) >> +{ > Please arrange for these functions to take a struct device rather than > a struct platform_device. The generic part of this driver should remain > bus-agnostic. > > Thanks. okay, is it good to replace "struct platform_device" with "struct device" ? Thanks : )