From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964894AbbBBJEZ (ORCPT ); Mon, 2 Feb 2015 04:04:25 -0500 Received: from hqemgate14.nvidia.com ([216.228.121.143]:14323 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932854AbbBBJET (ORCPT ); Mon, 2 Feb 2015 04:04:19 -0500 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Mon, 02 Feb 2015 00:53:25 -0800 Message-ID: <54CF3D49.5010802@nvidia.com> Date: Mon, 2 Feb 2015 14:33:05 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Nicholas Mc Guire CC: Mark Brown , Stephen Warren , Thierry Reding , Alexandre Courbot , , , Subject: Re: [PATCH 2/2] spi: tegra20-slink: cleanup wait_for_completion return handling References: <1422795727-29097-1-git-send-email-hofrat@osadl.org> In-Reply-To: <1422795727-29097-1-git-send-email-hofrat@osadl.org> X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: DRHKMAIL102.nvidia.com (10.25.59.16) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday 01 February 2015 06:32 PM, Nicholas Mc Guire wrote: > return type of wait_for_completion_timeout is unsigned long not int, this > patch adds an appropriate variable and fixes up the assignment. > As the string in dev_err already states "timeout" there is little point in > printing the 0 here as it just restates "timeout". Looks good to me. Thanks for fixing this. I think it is good if we fix the typo here also. Acked-by: Laxman Dewangan > - if (WARN_ON(ret == 0)) { > - dev_err(tspi->dev, > - "spi trasfer timeout, err %d\n", ret); > + if (WARN_ON(dma_timeout == 0)) { > + dev_err(tspi->dev, "spi trasfer timeout\n"); trasfer->transfer