mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Bryton Lee <brytonlee01@gmail.com>
Cc: linux-kernel@vger.kernel.org, acme@redhat.com,
	namhyung@kernel.org,
	"yrl.pp-manager.tt@hitachi.com" <yrl.pp-manager.tt@hitachi.com>
Subject: Re: [PATCH 1/1] Fix perf probe help message typo issue.
Date: Wed, 04 Feb 2015 10:03:08 +0900	[thread overview]
Message-ID: <54D16FCC.3090108@hitachi.com> (raw)
In-Reply-To: <CAC2pzGc-FnTp+-pAer6QhsOeA0adcbvdunf03qsdzOX3QJj7cg@mail.gmail.com>

(2015/02/03 21:56), Bryton Lee wrote:
> Fix perf probe help message typo issue.
> 

Yeah, that is a typo...

> Signed-off-by: Bryton Lee <brytonlee01@gmail.com>

Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>

Thanks!

> ---
>  tools/perf/util/probe-event.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
> index 94a717b..8d3ac0f 100644
> --- a/tools/perf/util/probe-event.c
> +++ b/tools/perf/util/probe-event.c
> @@ -1797,9 +1797,9 @@ static void print_open_warning(int err, bool is_kprobe)
>   const char *config;
> 
>   if (!is_kprobe)
> - config = "CONFIG_UPROBE_EVENTS";
> + config = "CONFIG_UPROBE_EVENT";
>   else
> - config = "CONFIG_KPROBE_EVENTS";
> + config = "CONFIG_KPROBE_EVENT";
> 
>   pr_warning("%cprobe_events file does not exist"
>     " - please rebuild kernel with %s.\n",
> @@ -1818,8 +1818,8 @@ static void print_both_open_warning(int kerr, int uerr)
>   if (kerr == -ENOTSUP && uerr == -ENOTSUP)
>   pr_warning("Debugfs is not mounted.\n");
>   else if (kerr == -ENOENT && uerr == -ENOENT)
> - pr_warning("Please rebuild kernel with CONFIG_KPROBE_EVENTS "
> -   "or/and CONFIG_UPROBE_EVENTS.\n");
> + pr_warning("Please rebuild kernel with CONFIG_KPROBE_EVENT "
> +   "or/and CONFIG_UPROBE_EVENT.\n");
>   else {
>   char sbuf[STRERR_BUFSIZE];
>   pr_warning("Failed to open kprobe events: %s.\n",
> 


-- 
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Research Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com



      reply	other threads:[~2015-02-04  1:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-03 12:56 Bryton Lee
2015-02-04  1:03 ` Masami Hiramatsu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54D16FCC.3090108@hitachi.com \
    --to=masami.hiramatsu.pt@hitachi.com \
    --cc=acme@redhat.com \
    --cc=brytonlee01@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    --cc=yrl.pp-manager.tt@hitachi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®