From: "Jan Beulich" <JBeulich@suse.com>
To: <mingo@elte.hu>, <tglx@linutronix.de>, <hpa@zytor.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86/Kconfig: avoid issuing pointless turned off entries to .config
Date: Thu, 05 Feb 2015 15:39:34 +0000 [thread overview]
Message-ID: <54D39CC6020000780005D6AE@mail.emea.novell.com> (raw)
Settings without prompts shouldn't normally have defaults other than Y,
as otherwise they (a) needlessly enlarge the resulting .config and (b)
if they ever get a prompt added later, the tracked setting of off will
prevent the devloper from then being prompted for his/her choice when
doing an incremental update of the configuration (make oldconfig).
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
arch/x86/Kconfig | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
--- 3.19-rc7/arch/x86/Kconfig
+++ 3.19-rc7-x86-Kconfig-cleanup/arch/x86/Kconfig
@@ -232,12 +232,10 @@ config ARCH_WANT_GENERAL_HUGETLB
def_bool y
config ZONE_DMA32
- bool
- default X86_64
+ def_bool y if X86_64
config AUDIT_ARCH
- bool
- default X86_64
+ def_bool y if X86_64
config ARCH_SUPPORTS_OPTIMIZED_INLINING
def_bool y
@@ -1110,10 +1108,10 @@ config MICROCODE_OLD_INTERFACE
depends on MICROCODE
config MICROCODE_INTEL_EARLY
- def_bool n
+ bool
config MICROCODE_AMD_EARLY
- def_bool n
+ bool
config MICROCODE_EARLY
bool "Early load microcode"
next reply other threads:[~2015-02-05 15:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-05 15:39 Jan Beulich [this message]
2015-02-19 0:26 ` [tip:x86/build] x86/Kconfig: Avoid " tip-bot for Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D39CC6020000780005D6AE@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®