mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Simon Glass <sjg@chromium.org>
Cc: Olof Johansson <olof@lixom.net>, Lee Jones <lee.jones@linaro.org>,
	Doug Anderson <dianders@chromium.org>,
	Bill Richardson <wfrichar@chromium.org>,
	Gwendal Grignou <gwendal@google.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Varka Bhadram <varkabhadram@gmail.com>,
	Paul Bolle <pebolle@tiscali.nl>,
	linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
	lk <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 0/7] platform/chrome: Add user-space dev inferface support
Date: Wed, 18 Feb 2015 10:27:15 +0100	[thread overview]
Message-ID: <54E45AF3.1010405@collabora.co.uk> (raw)
In-Reply-To: <CAPnjgZ2QQzdZSrJ8gFYzMiVEFT8y7jod993AeVkpTPpKhiQ8DA@mail.gmail.com>

Hello Simon,

On 02/18/2015 03:26 AM, Simon Glass wrote:
> 
> On 16 February 2015 at 01:19, Javier Martinez Canillas
> <javier.martinez@collabora.co.uk> wrote:
>> Hello Olof,
>>
>> On 02/02/2015 12:26 PM, Javier Martinez Canillas wrote:
>>> Hello,
>>>
>>> The mainline ChromeOS Embedded Controller (EC) driver is still missing some
>>> features that are present in the downstream ChromiumOS tree. These are:
>>>
>>>   - Low Pin Count (LPC) interface
>>>   - User-space device interface
>>>   - Access to vboot context stored on a block device
>>>   - Access to vboot context stored on EC's nvram
>>>   - Power Delivery Device
>>>   - Support for multiple EC in a system
>>>
>>> This is a fifth version of a series that adds support for the first two of
>>> the missing features: the EC LPC and EC character device interfaces that
>>> are used by user-space to access the ChromeOS EC. The support patches were
>>> taken from the downstream ChromiumOS 3.14 tree with the fixes and cleanups
>>> squashed to have a minimal patch-set.
>>>
>>
>> Any comments on this series? The last version was posted a couple of weeks
>> ago but the series have been in the list for months. Lee has already acked
>> the mfd changes so you can merge all through your chrome-platform tree if
>> you want.
>>
>> It wold be great if this series get in to have the EC user-space interface
>> supported and to minimize the delta with the Chromemium OS kernel since it
>> still has other features that needs to be upstreamed like multiple EC in a
>> system and access to vboot context stored in block device or EC's nvram.
> 
> Are you sure Olof is the right maintainer for this going to mainline?
>

The downstream ChromiumOS kernel has this stuff in drivers/mfd but Lee was
patient enough to explain to me why it does not fit there. So I think the
best place is drivers/platform/chrome/ which is maintained by Olof.
 
> I do feel for you trying to get all this in and have seen your many
> attempts. It has been in U-Boot for 18 months...I hope you get there
> in the end.
>

Thanks a lot for your empathy. I do hope to get there too since there are
still more features to match what is in the downstream tree but needs to
be based on this series.

> Regards,
> Simon
>

Best regards,
Javier

  reply	other threads:[~2015-02-18  9:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-02 11:26 Javier Martinez Canillas
2015-02-02 11:26 ` [PATCH v5 1/7] mfd: cros_ec: Use fixed size arrays to transfer data with the EC Javier Martinez Canillas
2015-02-02 11:26 ` [PATCH v5 2/7] mfd: cros_ec: Add char dev and virtual dev pointers Javier Martinez Canillas
2015-02-02 11:26 ` [PATCH v5 3/7] platform/chrome: Add cros_ec_lpc driver for x86 devices Javier Martinez Canillas
2015-02-02 11:26 ` [PATCH v5 4/7] platform/chrome: Add Chrome OS EC userspace device interface Javier Martinez Canillas
2015-02-26  0:54   ` Olof Johansson
2015-02-26  1:13     ` Gwendal Grignou
2015-02-26  9:08       ` Javier Martinez Canillas
2015-02-26 17:38         ` Olof Johansson
2015-02-02 11:26 ` [PATCH v5 5/7] mfd: cros_ec: Instantiate ChromeOS EC character device Javier Martinez Canillas
2015-02-02 11:26 ` [PATCH v5 6/7] platform/chrome: Create sysfs attributes for the ChromeOS EC Javier Martinez Canillas
2015-02-02 11:26 ` [PATCH v5 7/7] platform/chrome: Expose Chrome OS Lightbar to users Javier Martinez Canillas
2015-02-16  8:19 ` [PATCH v5 0/7] platform/chrome: Add user-space dev inferface support Javier Martinez Canillas
2015-02-18  2:26   ` Simon Glass
2015-02-18  9:27     ` Javier Martinez Canillas [this message]
2015-02-26  0:59     ` Olof Johansson
2015-02-26 16:00       ` Simon Glass
2015-02-26  0:57   ` Olof Johansson
2015-02-26 23:35 ` Gwendal Grignou
2015-02-27  0:11   ` Olof Johansson
2015-02-27  5:17     ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54E45AF3.1010405@collabora.co.uk \
    --to=javier.martinez@collabora.co.uk \
    --cc=corbet@lwn.net \
    --cc=dianders@chromium.org \
    --cc=gwendal@google.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=pebolle@tiscali.nl \
    --cc=sjg@chromium.org \
    --cc=varkabhadram@gmail.com \
    --cc=wfrichar@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome