From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755969AbbCCJfm (ORCPT <rfc822;w@1wt.eu>);
	Tue, 3 Mar 2015 04:35:42 -0500
Received: from szxga01-in.huawei.com ([119.145.14.64]:53716 "EHLO
	szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753132AbbCCJfj (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 3 Mar 2015 04:35:39 -0500
Message-ID: <54F5805A.7080000@huawei.com>
Date: Tue, 3 Mar 2015 17:35:22 +0800
From: Yijing Wang <wangyijing@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1
MIME-Version: 1.0
To: Bjorn Helgaas <bhelgaas@google.com>
CC: Jiang Liu <jiang.liu@linux.intel.com>, <linux-pci@vger.kernel.org>,
        Yinghai Lu <yinghai@kernel.org>, <linux-kernel@vger.kernel.org>,
        Marc Zyngier <marc.zyngier@arm.com>,
        <linux-arm-kernel@lists.infradead.org>,
        Russell King <linux@arm.linux.org.uk>, <x86@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Rusty Russell <rusty@rustcorp.com.au>, Tony Luck <tony.luck@intel.com>,
        <linux-ia64@vger.kernel.org>, "David S. Miller" <davem@davemloft.net>,
        "Guan Xuetao" <gxt@mprc.pku.edu.cn>, <linux-alpha@vger.kernel.org>,
        <linux-m68k@vger.kernel.org>, Liviu Dudau <liviu@dudau.co.uk>,
        "Arnd Bergmann" <arnd@arndb.de>,
        Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH v4 28/30] PCI: Export find_pci_host_bridge()
References: <1424938344-4017-1-git-send-email-wangyijing@huawei.com> <1424938344-4017-29-git-send-email-wangyijing@huawei.com> <20150303034048.GM11978@google.com>
In-Reply-To: <20150303034048.GM11978@google.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.177.27.212]
X-CFilter-Loop: Reflected
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2015/3/3 11:40, Bjorn Helgaas wrote:
> On Thu, Feb 26, 2015 at 04:12:22PM +0800, Yijing Wang wrote:
>> Export find_pci_host_bridge().
>>
>> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
>> ---
>>  drivers/pci/host-bridge.c |    2 +-
>>  include/linux/pci.h       |    1 +
>>  2 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/pci/host-bridge.c b/drivers/pci/host-bridge.c
>> index 4a2baa2..51e24f8 100644
>> --- a/drivers/pci/host-bridge.c
>> +++ b/drivers/pci/host-bridge.c
>> @@ -104,7 +104,7 @@ static struct pci_bus *find_pci_root_bus(struct pci_bus *bus)
>>  	return bus;
>>  }
>>  
>> -static struct pci_host_bridge *find_pci_host_bridge(struct pci_bus *bus)
>> +struct pci_host_bridge *find_pci_host_bridge(struct pci_bus *bus)
> 
> Please name this "pci_find_host_bridge()" or similar so it looks like other
> PCI functions.

OK, will rename it to "pci_find_host_bridge()" like others.


> 
>>  {
>>  	struct pci_bus *root_bus = find_pci_root_bus(bus);
>>  
>> diff --git a/include/linux/pci.h b/include/linux/pci.h
>> index 2f29e95..6ac7926 100644
>> --- a/include/linux/pci.h
>> +++ b/include/linux/pci.h
>> @@ -426,6 +426,7 @@ void pci_set_host_bridge_release(struct pci_host_bridge *bridge,
>>  struct pci_host_bridge *pci_create_host_bridge(
>>  		struct device *parent, u32 dombus, struct list_head *resources, 
>>  		void *sysdata, struct pci_host_bridge_ops *ops);
>> +struct pci_host_bridge *find_pci_host_bridge(struct pci_bus* bus);
> 
> I'm not sure this needs to be in include/linux/pci.h.  Wouldn't
> drivers/pci/pci.h be enough?

It's enough for this series, so I would move it to drivers/pci/pci.h, thanks!


> 
>>  /*
>>   * The first PCI_BRIDGE_RESOURCE_NUM PCI bus resources (those that correspond
>>   * to P2P or CardBus bridge windows) go in a table.  Additional ones (for
>> -- 
>> 1.7.1
>>
> 
> .
> 


-- 
Thanks!
Yijing