From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758469AbbCDNHh (ORCPT <rfc822;w@1wt.eu>);
	Wed, 4 Mar 2015 08:07:37 -0500
Received: from vi37-28-154-113.vibiznes.pl ([37.28.154.113]:40317 "EHLO
	vps-vb.mhejs.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1758348AbbCDNHf (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 4 Mar 2015 08:07:35 -0500
Message-ID: <54F70389.6020004@maciej.szmigiero.name>
Date: Wed, 04 Mar 2015 14:07:21 +0100
From: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0
MIME-Version: 1.0
To: Mark Brown <broonie@kernel.org>
CC: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        Timur Tabi <timur@tabi.org>, Nicolin Chen <nicoleotsuka@gmail.com>,
        Xiubo Li <Li.Xiubo@freescale.com>, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [ASoC]fsl_ssi: fix of_property_read_u32_array return value check
References: <54E1199F.3000107@maciej.szmigiero.name> <20150224082448.GY6236@finisterre.sirena.org.uk>
In-Reply-To: <20150224082448.GY6236@finisterre.sirena.org.uk>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

W dniu 24.02.2015 09:24, Mark Brown pisze:
> On Sun, Feb 15, 2015 at 11:11:43PM +0100, Maciej S. Szmigiero wrote:
>> of_property_read_u32_array returns 0 on success, so the return value shouldn't be inverted twice,
>> first on assignment then in condition expression.
> 
> This doesn't apply to current code, please check and resend.  Please
> also keep your changelog under 80 columns as covered in
> SubmittingPatches.
> 

Thanks for looking into it,

Against which tree/branch patches for ASoC should be generated?

Best regards,
Maciej Szmigiero