From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932582AbbCDPdI (ORCPT ); Wed, 4 Mar 2015 10:33:08 -0500 Received: from mail.bmw-carit.de ([62.245.222.98]:34074 "EHLO mail.bmw-carit.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932462AbbCDPdG (ORCPT ); Wed, 4 Mar 2015 10:33:06 -0500 Message-ID: <54F725A9.1050203@bmw-carit.de> Date: Wed, 4 Mar 2015 16:32:57 +0100 From: Daniel Wagner User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Boaz Harrosh , Jeff Layton CC: Jeff Layton , , , "J. Bruce Fields" , Alexander Viro Subject: Re: [RFC v2 3/4] locks: Split insert/delete block functions into flock/posix parts References: <1425306313-7234-1-git-send-email-daniel.wagner@bmw-carit.de> <1425306313-7234-4-git-send-email-daniel.wagner@bmw-carit.de> <20150302195502.0c3a59e3@tlielax.poochiereds.net> <54F714B1.1070908@bmw-carit.de> <54F71DFE.8040703@gmail.com> In-Reply-To: <54F71DFE.8040703@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/04/2015 04:00 PM, Boaz Harrosh wrote: > On 03/04/2015 04:20 PM, Daniel Wagner wrote: >> On 03/03/2015 01:55 AM, Jeff Layton wrote: >>> On Mon, 2 Mar 2015 15:25:12 +0100 >>> Daniel Wagner wrote: >>> > <> >> I have fixed that stuff and now I am testing it. Though it seems >> that there is a memory leak which can be triggered with >> >> while true; rm -rf /tmp/a; ./lease02 /tmp/a; done >> >> and this happens also without any of my patches. Still trying to >> figure out what's happening. Hopefully I just see a ghost. >> >> slabtop tells me that ftrace_event_field is constantly growing: >> > > check out the Kernel's leak detector it is perfect in showing you > what was the exact call stack of the leaked memory. Thanks for the tip. Will use it in future :) I have done a quick bisect limit the search on fs/locks.c. I suspect that the file_lock_context refactoring is the source of the leak. bisect agrees with me 8634b51f6ca298fb8b07aa4847340764903533ab is the first bad commit commit 8634b51f6ca298fb8b07aa4847340764903533ab Author: Jeff Layton Date: Fri Jan 16 15:05:55 2015 -0500 locks: convert lease handling to file_lock_context Signed-off-by: Jeff Layton Acked-by: Christoph Hellwig :040000 040000 4114db9392dc4dadb30664b71a954321e5e87bab 5b9abbaf1808a7c926c09fa2164044e0cc26fd54 M fs :040000 040000 bd569f527a195edf673c4f7d0e80bf356c7f8d1b 6362646e04dd83efc1a9e92877900797ac879e9a M include