From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756462AbbCEPOy (ORCPT ); Thu, 5 Mar 2015 10:14:54 -0500 Received: from lists.s-osg.org ([54.187.51.154]:45924 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756158AbbCEPOx (ORCPT ); Thu, 5 Mar 2015 10:14:53 -0500 Message-ID: <54F872E2.9000708@osg.samsung.com> Date: Thu, 05 Mar 2015 08:14:42 -0700 From: Shuah Khan Organization: Samsung Open Source Group User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Michael Ellerman , Namhyung Kim , Dave Jones , Steven Rostedt CC: Linux Kernel Subject: Re: [PATCH] Remove redhat'ism from ftrace selftests. References: <20150224161927.GA4998@codemonkey.org.uk> <20150224131810.38d73389@gandalf.local.home> <54ECC182.5080109@osg.samsung.com> <20150224182459.GA9018@codemonkey.org.uk> <20150228031602.GD15964@danjae> <54F64C32.1030906@osg.samsung.com> <1425466067.32154.9.camel@ellerman.id.au> <20150304124457.GK27046@danjae> <1425518337.32154.17.camel@ellerman.id.au> In-Reply-To: <1425518337.32154.17.camel@ellerman.id.au> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/04/2015 06:18 PM, Michael Ellerman wrote: > On Wed, 2015-03-04 at 21:44 +0900, Namhyung Kim wrote: >> >> I think that there's no need to even call true or echo.. >> >> From 0549544e8e982df6478f11e2b4fe419f94c22434 Mon Sep 17 00:00:00 2001 >> From: Namhyung Kim >> Date: Wed, 4 Mar 2015 21:26:38 +0900 >> Subject: [PATCH] ftracetest: Do not use usleep >> >> The usleep is only provided on distros from Redhat so running ftracetest >> on other distro resulted in failures due to the missing usleep. >> >> The reason of using [u]sleep in the test was to generate (scheduler) >> events. But as we use 'cat trace | grep | wc -l' to read the events, >> the command themselves already generate some events before reading the >> trace file so no need to call [u]sleep explicitly. >> >> Reported-by: Michael Ellerman >> Reported-by: Dave Jones >> Signed-off-by: Namhyung Kim > > Thanks, this is working for me. > > Tested-by: Michael Ellerman > Steve, Do you want to make a call on which one you want me to take it through between these two patches - one from Dave and the other from Namhyung Kim. Please send me the patch I have to pull in. Namhyung Kim's patch isn't in the format I can apply and I don't have Dave's patch in my inbox. thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978