From: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: gregkh@linuxfoundation.org, mdcasey@chabloom.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: rtllib_wx: code style improvements
Date: Wed, 11 Mar 2015 08:32:41 +0100 [thread overview]
Message-ID: <54FFEF99.4030806@gmail.com> (raw)
In-Reply-To: <1426028514.18060.64.camel@perches.com>
On 11.03.2015 00:01, Joe Perches wrote:
> On Tue, 2015-03-10 at 23:53 +0100, Mateusz Kulikowski wrote:
>> - Replaced printk() with netdev_*()
>
> trivia:
>
>> diff --git a/drivers/staging/rtl8192e/rtllib_wx.c b/drivers/staging/rtl8192e/rtllib_wx.c
> []
>> @@ -423,11 +421,8 @@ int rtllib_wx_set_encode(struct rtllib_device *ieee,
>> NULL, (*crypt)->priv);
>> if (len == 0) {
>> /* Set a default key of all 0 */
>> - printk(KERN_INFO "Setting key %d to all zero.\n",
>> - key);
>> -
>> - RTLLIB_DEBUG_WX("Setting key %d to all zero.\n",
>> - key);
>> + netdev_info(dev, "Setting key %d to all zero.\n", key);
>> + RTLLIB_DEBUG_WX("Setting key %d to all zero.\n", key);
>
> This isn't something you've created but it
> seems more than a bit nonsensical to emit the
> same message at different logging levels.
Thanks for hint - I'll throw away duplicate messages for v2.
As for all standalone RTLLIB_DEBUG* entries (in whole driver) -
I think it may be better to replace them with netdev_dbg, and use dynamic debug when needed.
M.
next prev parent reply other threads:[~2015-03-11 7:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 22:53 Mateusz Kulikowski
2015-03-10 23:01 ` Joe Perches
2015-03-11 7:32 ` Mateusz Kulikowski [this message]
2015-03-11 7:46 ` [PATCH v2] " Mateusz Kulikowski
2015-03-11 7:53 ` Greg KH
2015-03-11 22:19 ` Mateusz Kulikowski
2015-03-12 23:53 ` [PATCH v3 0/6] staging: rtl8192e: fix coding style issues Mateusz Kulikowski
2015-03-12 23:53 ` [PATCH v3 1/6] staging: rtl8192e: fix coding style issues (merge broken strings) Mateusz Kulikowski
2015-03-13 0:27 ` Joe Perches
2015-03-16 21:57 ` Mateusz Kulikowski
2015-03-17 0:17 ` Joe Perches
2015-03-16 8:44 ` Dan Carpenter
2015-03-16 21:45 ` Mateusz Kulikowski
2015-03-12 23:53 ` [PATCH v3 2/6] staging: rtl8192e: fix coding style issues (replace min with min_t) Mateusz Kulikowski
2015-03-12 23:53 ` [PATCH v3 3/6] staging: rtl8192e: fix coding style issues (spaces before semicolon) Mateusz Kulikowski
2015-03-12 23:53 ` [PATCH v3 4/6] staging: rtl8192e: fix coding style errors (macros in parentheses) Mateusz Kulikowski
2015-03-12 23:53 ` [PATCH v3 5/6] staging: rtl8192e: rtllib_wx: fix coding style (printk -> netdev_*) Mateusz Kulikowski
2015-03-12 23:53 ` [PATCH v3 6/6] staging: rtl8192e: rtllib_wx: remove duplicate messages Mateusz Kulikowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FFEF99.4030806@gmail.com \
--to=mateusz.kulikowski@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mdcasey@chabloom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome