From: "Li, Aubrey" <aubrey.li@linux.intel.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>,
"alan@linux.intel.com" <alan@linux.intel.com>,
Arjan van de Ven <arjan@linux.intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Brown, Len" <len.brown@intel.com>,
"H. Peter Anvin" <hpa@linux.intel.com>,
x86@kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] x86: Bypass legacy PIC and PIT in ACPI hardware reduced mode
Date: Wed, 11 Mar 2015 15:51:36 +0800 [thread overview]
Message-ID: <54FFF408.1000703@linux.intel.com> (raw)
In-Reply-To: <20150311062324.GA29788@gmail.com>
On 2015/3/11 14:23, Ingo Molnar wrote:
>
> * Li, Aubrey <aubrey.li@linux.intel.com> wrote:
>
>> On a platform in ACPI Hardware-reduced mode, the legacy PIC and PIT
>> may not be initialized even though they may be present in silicon.
>> Touching these legacy components causes unexpected result on system.
>
> s/causes unexpected result on system/
> causes unexpected results on the system
>
>>
>> On Bay Trail-T(ASUS-T100) platform, touching these legacy components
>
> s/On Bay Trail-T(ASUS-T100) platform/
> On the Bay Trail-T(ASUS-T100) platform
>
> Ok, my final bike shed painting job would be to move the
> 'acpi_gbl_reduced_hardware' flag check inside acpi_reduced_hw_init():
> that makes it nicely self-sustained and all in a single place.
>
> With that fixed it looks good to me.
Thanks, I'll cook v3 soon, :-)
>
> Should I merge it for v4.0 upstream merge, in tip:x86/urgent?
>
> The 'touches hardware in unexpected ways' aspect qualifies it for
> urgent treatment IMO.
Currently the unexpected result is that it blocks a low power idle
during suspend. I'm not sure if it can be for x86/urgent. But it would
be nice if it can be a bug-fix in v4.0.
Thanks,
-Aubrey
>
> Thanks,
>
> Ingo
>
>
prev parent reply other threads:[~2015-03-11 7:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 4:33 Li, Aubrey
2015-03-11 6:23 ` Ingo Molnar
2015-03-11 7:51 ` Li, Aubrey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FFF408.1000703@linux.intel.com \
--to=aubrey.li@linux.intel.com \
--cc=alan@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=hpa@linux.intel.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome