From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC8E830EF67 for ; Mon, 22 Dec 2025 10:31:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766399499; cv=none; b=nkIuFkmDis3eW8Q9QqUHkI5tEZc1L86V4Wn6Zmi7qOg5NtTCykqrfW4N/BbYrkYmZnTyCnfW0E4EPSSYA2UGGLWj+cbK1C0r3pgjoqjo0Ek+3SbJ26hVTk4PByS7T8puDJ4GBsT9VK6iS1VibyAEPIajaa7Piq05lUxa0SLfXJQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766399499; c=relaxed/simple; bh=XZz1xE+YE9rIrAv8TPfmjsTJZft86uRH+WeioLmBXPs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Hg0cAyv/MRxuftvbeyx4IDPpe5B1963rmA42IGK1MntGazjKs3U3YEBQpKY96WJBGBbxl0BwS43kg+rLFJcdaQMRglkNbyEn/ilXQEkPDU1lKc/QWxou2IBX12fLfUE3xpb8RhD+v8jR3fhtcYZy1wYfhYxXTak48IJttX04zC0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gzhKcOo6; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Olzfmtf2; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gzhKcOo6"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Olzfmtf2" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BM807jE3864031 for ; Mon, 22 Dec 2025 10:31:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sd3ZsPbmm/TqCzyvuwxbyZGAw0bOEcr60FfnyA+uFck=; b=gzhKcOo6lqBBJNa3 c3Kn6JGPrLuJ4l9ysd+FN10JKgh+8loTKnkeQiFD+rHdHMjGA6ISKqRevxuNMeHz IMKM8cO1nts5Y7VYIvlLhvgXKOLlGS0j6xM6Lj6zgJp9pCDmfKbSfLI4w86klXpy UcNl1/J60YdBRQlfqizypQN2sc55NdaZKmx9PfGV/z9hU2HcmI/YSm39ej6IKdIr mu+kD82d3FfbmWSm5vqpL3tK+Tr+aXeL7yU2UaZAsKJP9ZRiEr5QuAuLvamdUyMH StVRu713dKM+6ytUtYCDpU8dA6LjPH+Cu2g8+uMsP57P9niQ1hoWzC+PaPeCNuPS 7lj/jg== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b5mru4nxx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 22 Dec 2025 10:31:36 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-34c66cb671fso5578992a91.3 for ; Mon, 22 Dec 2025 02:31:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766399496; x=1767004296; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sd3ZsPbmm/TqCzyvuwxbyZGAw0bOEcr60FfnyA+uFck=; b=Olzfmtf2RP+s3H/yxmUDixQCSKpJNG752UR5bSCUSGwnP1OYgiZcw8PlEHaFXHZK8E ZMqdiaHWvjbuFpotSP3CqVI3P06KxPGxVssCCccMOXmY4KsWcRuYAfdRVS9Cpy48Ljsh tNaap2kcKuS1PE2nqsBS+ONpiRe5+hYoGqmzOusZKmqGJ2d96qIF2xV7KEC6PD3clic7 EhOPPFot6nBzSe+X4zfcRASsO2xqr48G0+nQUlXhFEMu6V/d3Kz5N0ifTl7Pasbx9l1z 1rDzQ2fw0GN6LrOTJtb4PAOU6I3BakQm9ZeDgTOpzxl9F3lNsBHFAbQIYCCwTXEqoNKZ EWbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766399496; x=1767004296; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sd3ZsPbmm/TqCzyvuwxbyZGAw0bOEcr60FfnyA+uFck=; b=F+21oJcpjHMm/GAQf7LFQMnktCShVAkTtfW6qRL03a/WZVVpPF6wZ7CNEwrN/u0Ag5 AwMtHdSyAs9pI2QqNMh+vC9mcu0eDvyTysvqZFlz5qZJpy6qwGYT+RUAquuwFjXHEMQo 4ikp/6SyLX2Bue+CkddoWT3dTroKEmnw0QYAIhz2cLIDXLemaiyjYAc1ZiqEsihbYi3d B3y3TgA+KJ06CbIR83k4Du3bw/PLIUbCBRQ6tCSuPp5usA9oUWJwXyyOkfEAmXrMU5p1 qQxq6Tgg0dBk5dxbxjMftstRA7t+woyx+wb3KwWFkmmqScMFxDPhIkTOGmoyyoeKU02L crMQ== X-Forwarded-Encrypted: i=1; AJvYcCXDSiRRJek+3JbIVz2kUdMYVEKD5gMAY0mdPyYTLcANOrOPRaJYg/1DG1+D/3ThpCJLtDaBXUKkssdLbdw=@vger.kernel.org X-Gm-Message-State: AOJu0YwzK/RsRg3bxfmRsr1xZW6GkteiZ7Z8EV6KPMB1pOmZRHHVwmOF wrIeMKF9XvtYSgMbyrNOMnQitV7KuOhn5DNqJZoRIMDIuOyHt1hLOrFQnaG8XLDuleXmLD2UzBx fW+6XI7mLTpTI7r6Gf69yOFNZXR5i0B0SJf1YIZQ7kGd+UnUf97PxBsJI2S0HFDVIdsU= X-Gm-Gg: AY/fxX4rvw/CdPdZDIF5qfQnPy9nNgBNdCSBjnRe9x8z55jkD0in7C9OFgOOKJavupl 9dx87OUOjcUSiUGoKR4ciVxIK5tLYAAm/7B/FrJTYbPhWe4DxCiuTelqtyZ8gr8Jh5FcqQRbD2H oQQyDIg5qFOylyFigAmCYd2Ceh/r//ODIJwOsJJUcgUskN/pb+0GvgDc17ddZgtXvuxsAXgf1lf rr1u5Arg9xt07gabBeT5aYTEV8JRnGWLH+weUs7yn3R+4PnTyvMhgwzflRPGGy8UHFdsmsYtPi0 Qu8vlDCeTg+x1Yla0fTbjrc/UYujwJq4/BkgwqXKRfDtM7mBbQc8cAnhKU/o9fL+1jYeqjVfb3/ lreMeOeaJCn7ULPVXipNmQxD0+hqVU87iq4qtapuRv7jz X-Received: by 2002:a05:6a20:7285:b0:352:3695:fa64 with SMTP id adf61e73a8af0-376a94bf23emr10821138637.37.1766399496211; Mon, 22 Dec 2025 02:31:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IEuhGQa6gBuPSQ7RJMYPiXhgGuMHU1tafo5ELmcsVLK1rusMvXx55oS11VPo8V4uxFpTc3UrA== X-Received: by 2002:a05:6a20:7285:b0:352:3695:fa64 with SMTP id adf61e73a8af0-376a94bf23emr10821111637.37.1766399495655; Mon, 22 Dec 2025 02:31:35 -0800 (PST) Received: from [10.217.219.25] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c1e7bc68ab5sm9256293a12.17.2025.12.22.02.31.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Dec 2025 02:31:35 -0800 (PST) Message-ID: <54a25608-57d3-452c-a838-952d0935ef37@oss.qualcomm.com> Date: Mon, 22 Dec 2025 16:01:30 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/2] net: mhi: Enable Ethernet interface support To: Andrew Lunn Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Manivannan Sadhasivam , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org References: <20251209-vdev_next-20251208_eth_v6-v6-0-80898204f5d8@quicinc.com> <20251209-vdev_next-20251208_eth_v6-v6-1-80898204f5d8@quicinc.com> <5a137b11-fa08-40b5-b4b4-79d10844a5b7@lunn.ch> Content-Language: en-US From: vivek pernamitta In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjIyMDA5NSBTYWx0ZWRfXw3cqht0D8TZx WjjWp/95PwOHSPC/747alu4lOcKyx3CgcCSQ+0aLafxXEf6O9tQDHPS9bmB+HS4HaWdDfrDft9x xpZoYpmU8eVyP1iWqdppxypB8mWjuoZaEqrY7kfPoX+zqM/VWXC8dd/0QBN5MRMAEkQOUM7ozkX LyOmH7XwsdDZxDhLuPZyGYChtw9KG0fgYgt6I6l7Z1QXD6Yt7Tef7A2cVNBXRPzz1NzDB+KdPmH 8Ova/1hXBYu0jQid1UrGvEej3OSKM4Rv72uiuWY6zUw7+wUPC/Tb91CFK3HXQWCfK1cPJqu5m0Y R8merxpp8oRQKfNxpkjO8TIFECAfmolTOZUuAeY+MD8CxtNgxjzgfUMmdBabkcUhV1kT+XjO4uo ZrEdDQNeKcKTJOw64ng8PVavK596UcO/e3nB5sJdFX4ebUe5gz+lfYWb2KbJFMNc/jfLIh5574n otuNxq49hK7QVv8bNoQ== X-Authority-Analysis: v=2.4 cv=VMnQXtPX c=1 sm=1 tr=0 ts=69491e09 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=P-IC7800AAAA:8 a=82xI_hd8Nmh2SGOlAZoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-ORIG-GUID: doDfboWoofYBUVPkKpAFcq-nGV42SVhk X-Proofpoint-GUID: doDfboWoofYBUVPkKpAFcq-nGV42SVhk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-21_05,2025-12-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 phishscore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 adultscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512220095 On 12/10/2025 10:20 PM, Andrew Lunn wrote: > On Wed, Dec 10, 2025 at 10:46:11AM +0530, vivek pernamitta wrote: >> >> On 12/9/2025 7:06 PM, Andrew Lunn wrote: >> >> ndev = alloc_netdev(sizeof(struct mhi_net_dev), info->netname, >> - NET_NAME_PREDICTABLE, mhi_net_setup); >> + NET_NAME_PREDICTABLE, info->ethernet_if ? >> + mhi_ethernet_setup : mhi_net_setup); >> >> Is the name predictable? I thought "eth%d" was considered >> NET_NAME_ENUM? >> >> https://elixir.bootlin.com/linux/v6.18/source/net/ethernet/eth.c#L382 >> >> Andrew >> >> For Ethernet-type devices, the interface name will follow the standard >> convention: eth%d, >> For normal IP interfaces, the interface will be created as mhi_swip%d/ >> mhi_hwip%d. >> The naming will depend on the details provided through struct mhi_device_info. > > Take a look again at my question. Why is NET_NAME_PREDICTABLE correct? > Justify it. Especially given what alloc_etherdev_mqs() does. > > Andrew You’re right—eth%d should use NET_NAME_ENUM. I’ll update the patch to use NET_NAME_ENUM for both Ethernet-type interfaces and for non-Ethernet (SW/HW IP) interfaces. Thanks for the pointer. Regards Vivek