From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3D9E396587 for ; Fri, 17 Apr 2026 12:37:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776429438; cv=none; b=BvhKA4SIicYHO3FC22TSuI7b9HkGei4dKFQZbeiBzuBXwS0iZOKuyK5ugd31NC9CrlQyxHtvqn6xO6CvGAy1IzMMmrND9GFkPSSDyZCx84sPegx53uagqHXYXlYVAmIdPElCdfNx1J5qlL/mU8iCCGV6K8tp0NYbZqHRf7hHl7w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776429438; c=relaxed/simple; bh=N35rTkhOKN3ePSz0lSG1W/FT/xQCyJLnN8AHKDEboJo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tlfYYiv/JkHoUno+390uahmEup5N88mLxdnIFk1nIlaOSMPBuKwsgQG30ygEDHvsHEovZA5b3ax/ekwlyIP2UEUkm9nbYhYiqwyPNMaRglsBVB2VvotOExS09hwtS8lnO2xawbmtEql1bxC+Aq0KRem9yXd48+4gE5GFuZlQkng= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Ga3R05o2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jmELN605; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Ga3R05o2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jmELN605" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63H7jXIH1872644 for ; Fri, 17 Apr 2026 12:37:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= syN7s3fwKBB2b0e/L5u7fo14eh4La/wkEmwmtd3jb1U=; b=Ga3R05o2+xKIKWml x9yiWLHQ6M2INngNQPokLoM8uhOWhJEp88merHbViBOqB10gOI5HtU0xzdj5LLcy JDVOBX5EWUdHqA7wrTXsl9Zo21IAcnQ9unz4l27O+jtUgcVFLMrjnfPtXcsinddK XKko5bf23ekjFxSkS3517Q8kkFPQARMvE8it/K8ljWNAK9RFoaYCR5dOQAGKqQ/8 tBytvuO/omYdy9ut+G8E6NdARuCJsfAbS4nIo1CVyMmijowfaBV6uLTOMFx+Otxp gELRio8uS+uCDMTFGw89YcrLgYKlstd+ve9FgrP8rYRpFIUoCdXWT4IIrgw2vrTh FYwSqg== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dk2knc0se-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Apr 2026 12:37:15 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-50d5d076d88so1385001cf.1 for ; Fri, 17 Apr 2026 05:37:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776429435; x=1777034235; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=syN7s3fwKBB2b0e/L5u7fo14eh4La/wkEmwmtd3jb1U=; b=jmELN605ZeZaqjDzEX0P+Y4Nf1XtLUsNNZz+dxImHBPwODTFBme0aciD21Xd9wEMgk 7gtBy1VBVEK63Ihw2CGbpmtTyogizoJyEyZIu8Dr6gK11bU7X2nGJDedJkKD4vMbsIBH 56xqd685CXihv5T3wvaye7c3suS6iUBh8U4i3r2r/zoPps6dxCfu7fB/XFxJwcqJBiTc R14KxbRVbETLtQT3rvsFH6pm3lu0HqRXMMCtmgG36db9rXi+usYGDUkPp8EjMI0J9vO3 Zc2ULE8sVzrIPB1xwknNN32vFoGouBtIImCq++7ZiPiux6oWRClcM4k24CeEEHTNxic4 L04w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776429435; x=1777034235; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=syN7s3fwKBB2b0e/L5u7fo14eh4La/wkEmwmtd3jb1U=; b=COmDcnePxOJX3e1aNddpwk1RRwqXU0RMfIXeFxtQe8i3/4BTetgr/UsSTmTsp+6Lx8 P02qIgO9T9uS8LddTovsHgF45u/pponInjSBVVPF0sNCuQ91BffbnyQt55/eD5hsNJRJ WGqw8jc8mbnAS1y7RX1oboszhlRv2WWjza3ZqOhnKavAMo43kkmeuvG+EyTTib+MbtRx Wp2q//cEsBruVRwnzo1th+Ul0zmU54B1zwIrqSj50b9Fajmwv7sNIYqJSF97/dchje4V CVuerVm8OurbO766RcrFh00DPW5LSzBQuE20RFxVcN95ZCafftYbkJxHoc37fB/6xtJW J4Wg== X-Forwarded-Encrypted: i=1; AFNElJ+nZDXi0pMjOTyvnnbNy0MIvLRciY9AM1eL+igChFDYjUdh7b+yVzQa4FFNhzTNegAsr217sNstkUOUlQI=@vger.kernel.org X-Gm-Message-State: AOJu0YzQHm13yig5rMDd4VirDkRdQKweVeL0o2dVrpJbFcm56oVjQ/oK fQ0J7dVL7LdbJbbgfkGNeeuOn7MxZrN/mNs+qRYuJa53QNX3DOBXRvU3al6rdmbVQpNIitqWxfV E1wDfVp1pbXrOOvnjItH4RVuuz7SqHIZwjfKFo4b15s0RYzcG6NxgkSNZtNPYKkvBAGI= X-Gm-Gg: AeBDiesnvZPU4KSZclYiGhXTkbMH47lYVnUTbkyj8TsNLGnc9g7zZQEuVNLtRiBu5T0 ifxWtJy3CcF5Iajby+RUV5CAwZQiOGDejjsduqNuSIr0Hmwy0YYWMIiL/HdKwbgfcMeF4W9xXyp ye3jdcgYMwEjXtVazFKsgTtzKsZNqkPpEvMe9hfre10UTYQi49NDu2NSvKVdZ0aHWkbO0V22AkM tbP65Jn439B5918MOlHA7OvIBaq5VhzUVpHE2+KJxOpGLlvEbbkPcff0UBo3/Gw5KwFrkkVVK3n WQfY2HTPMlb2jou4PCCm2gqjxu8w3vpiICyVmxotxbm5tdWnV5POpLjqU2BWUBvQjgFMLxNyuaW fQ2wTmrRU4dfRNX5VD3ExIa9Dh1hp2LkIcySCQZe33M+rSdCD/FxLnn+wyJhZycGS5JG4R1tIPg cizzKZfGxs4XAbfQ== X-Received: by 2002:a05:622a:5c13:b0:501:5260:51e9 with SMTP id d75a77b69052e-50e36c65be4mr24027961cf.7.1776429434883; Fri, 17 Apr 2026 05:37:14 -0700 (PDT) X-Received: by 2002:a05:622a:5c13:b0:501:5260:51e9 with SMTP id d75a77b69052e-50e36c65be4mr24027521cf.7.1776429434320; Fri, 17 Apr 2026 05:37:14 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ba4512115d6sm52459666b.7.2026.04.17.05.37.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Apr 2026 05:37:13 -0700 (PDT) Message-ID: <54ab414e-a33e-4cdb-a125-5a980ea7e851@oss.qualcomm.com> Date: Fri, 17 Apr 2026 14:37:11 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp: use refgen regulator for DSI To: Pengyu Luo , Dmitry Baryshkov Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260228125431.23098-1-mitltlatltl@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: deHXXQfHe-5In1wcCNVU9CJ5eiB9gji4 X-Authority-Analysis: v=2.4 cv=XNoAjwhE c=1 sm=1 tr=0 ts=69e2297b cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=IGz76sYE0BYaplGTJ5AA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-ORIG-GUID: deHXXQfHe-5In1wcCNVU9CJ5eiB9gji4 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE3MDEyMyBTYWx0ZWRfX97WMoG5PoVSR 5Krywe8PA93lMzfVlH4wfwGwvSZlgsKXqfvK1vVH63LNGyoxBpm2gQ4FgMivF+YjbRjA6iNjXZO 1MuLc7/Xh4UzOqNsbGr0XykV2TdNxysXIDIu7QGj8Z5M6w3mkCQBTt+kKpE9raktmoj8nn0NGqD MtkfgTE1xM83n12uhrmuR7ybOwoaK810Gamsqkq0eGBEu/oZYLmeI3q/IujT+ErUSRcbKaBhMQz 48aTVAahdhWDeUPWd5aS1O1UMFuXAjRdcEIWQ8i323KBBZo/Vt2uxLTza5eV8Q930bpmXFU8hq9 rybYW4C5CEzCaGTqHXYDuL6tGhTVDl4+KoLQf+cX70RU+xJ4uIH2TBo5CAP9fUeM4eRScy/vUbT r+JspmEBLstVhKOE0RD16eN+arnBVfqnNQqrc1vNcSfFdpF+u7OR0+xrnFOzc4ZuQdaMiUbkMHs IkUHKuGc4wM++c5/bQQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-17_01,2026-04-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 priorityscore=1501 suspectscore=0 spamscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604170123 On 4/17/26 2:23 PM, Pengyu Luo wrote: > On Sat, Feb 28, 2026 at 9:13 PM Dmitry Baryshkov > wrote: >> >> On Sat, Feb 28, 2026 at 08:54:30PM +0800, Pengyu Luo wrote: >>> Use it for the DSI controllers, since DSI nodes have been added. >>> >>> Signed-off-by: Pengyu Luo >>> --- >>> This patch depends on the below series: >>> https://lore.kernel.org/linux-arm-msm/20260228101907.18043-1-mitltlatltl@gmail.com/ >> >> Why was it not squashed into that series? I'd assume that DSI nodes are >> incomplete and are working "by luck" without the refgen supplies. >> > > Today, I did a casual read. I found the register(0x8900000 + 0x80) to > enable refgen is always 0 on windows. The refgen driver may be not > compatible with sc8280xp or the DT configuration is wrong. The Linux driver casts a software vote. Most newer SoCs should have a separate hw line between the PHYs and the REFGEN regulator to take care of it automatically. Even if a little unnecessary, this won't hurt I *think* base+0xc & BIT(3) should tell you whether the power is actually flowing at a given moment Konrad