From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756703AbdDQPac (ORCPT ); Mon, 17 Apr 2017 11:30:32 -0400 Received: from mout.web.de ([212.227.17.12]:50679 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754636AbdDQPaa (ORCPT ); Mon, 17 Apr 2017 11:30:30 -0400 Subject: [PATCH 20/25] net: mvpp2: Adjust a null pointer check in mvpp2_egress_enable() From: SF Markus Elfring To: netdev@vger.kernel.org, "David S. Miller" , Florian Fainelli , Jarod Wilson , Jisheng Zhang , Mirko Lindner , Philippe Reynes , Russell King , Sergei Shtylyov , Stephen Hemminger , Thomas Petazzoni Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <54acb3f4-8a0c-90ba-4267-f62e10baa252@users.sourceforge.net> Date: Mon, 17 Apr 2017 17:30:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:H2D6OXkEPDLtFN5B/QEbizfymps64MQC6MAlCfMJ8Bxb8es1go8 wXKAv+xpZdn0kiabksRcrQH8pmdI6noWEe8QYhvx0Fr7LL6/w2O6VJZh2fXSxBTMk0SWYUa lCDiXmI6GtNuBJiudawuZpXQZaeH0OTjMkH4JNkk/YIpZWQBnbnqzQtXa+ySa07tfIRBb7f J9FiguehvQw6zqywrdxVA== X-UI-Out-Filterresults: notjunk:1;V01:K0:bPJXYDQe+Fc=:LLEjWRWoLN+d9V3YymT5pM KuaDNwcQ2dFwLdRNPb9QE/Llx6K/Y6g8PmA0L5mYVfkDdl2E5ikO1cqxH2yA4WOWacLqRCvEv 7MDZgz+Ku3IBCYqXkn3wgC746v2Yckty9Nsl9wDCUNpqkWyb25rxWMB9Vidoj2vXLgkWpGlkM 5NRXM7yojtGupZTFYIRee6+y1pd/oY0VpWRKeEqRZCfuFz7QF2y9LuAVd47/AHgYxbaoEtZUz 4edsgQO52qrN/id0Z3czDLs2PxMFiUddYeVvnT+gzKJSZUim0urJEKa/gRgoB+XaXbPCqvedT 5qj+87X489oRAcjHuqgga4hnFRghKqoRW10MEUl+T9/n/OGYzz4QFr5WBcZGGN4IVssGhywbJ pIiHVnIBINGoUe+kk7QkiYeG9Pv8r0anlR07JzhNB1ICLD/mzmmqPSePI/GiSf/tBet0z2axM hwpl+TI7pD8sCDPlPDVDNJxn5UuY2B/tfpIvL6ZgiBf09V38dMRNxLEDOE51W+dH/gJ/Qf3ma 2aAwsp14t8JUiDImCKFoIjTHzp5F0VNBs9y3twVDpjgWYX1sbzH+yvd4t4qO3uRuZAG6/U4AW s2ldu9VRJlMXSTidnqqjZO+iFs1Vgnb91QhwoGTIGfyCXWQ27WCYNEbYoQX4E3BvSxL8YAJJY 1Fl4VQz20aZ46zH+Dx0U//YSiETZRDL05yHhajH8GpnSSFgEsBEA2IKAuKNSfZRBfNtcgEi+x au1OVo//vX80Q6Jyjdolp2AF+Uascx8X9eT9WSTnd8PFpfegwbK8+f9FkRsXQ1/MsU05QRepk H//2cAo Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 17 Apr 2017 14:07:52 +0200 The script "checkpatch.pl" pointed information out like the following. Comparison to NULL could be written "txq->descs". Thus fix the affected source code place. Signed-off-by: Markus Elfring --- drivers/net/ethernet/marvell/mvpp2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c index 3bdd3f1fe34e..9b875d776b29 100644 --- a/drivers/net/ethernet/marvell/mvpp2.c +++ b/drivers/net/ethernet/marvell/mvpp2.c @@ -4415,7 +4415,7 @@ static void mvpp2_egress_enable(struct mvpp2_port *port) for (queue = 0; queue < txq_number; queue++) { struct mvpp2_tx_queue *txq = port->txqs[queue]; - if (txq->descs != NULL) + if (txq->descs) qmap |= (1 << queue); } -- 2.12.2