Re: [PATCH v3 3/3] drm/amdgpu: Change type of module param `ppfeaturemask` to hexint

["Christian König" <christian.koenig@amd.com>]

Am 23.07.20 um 15:44 schrieb Paul Menzel:
> Dear Linus, dear Christian,
>
>
> Am 03.07.20 um 17:29 schrieb Christian König:
>> Am 03.07.20 um 16:29 schrieb Paul Menzel:
>>> The newly added hexint helper is more convenient for bitmasks.
>>>
>>> Before:
>>>
>>>      $ more /sys/module/amdgpu/parameters/ppfeaturemask
>>>      4294950911
>>>
>>> After:
>>>
>>>      $ more /sys/module/amdgpu/parameters/ppfeaturemask
>>>      0xffffbfff
>>>
>>> Cc: amd-gfx@lists.freedesktop.org
>>> Cc: linux-kernel@vger.kernel.org
>>> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
>>
>> Reviewed-by: Christian König <christian.koenig@amd.com> for this one.
>>
>> Feel free to add my Acked-by to the other two, but I'm not familiar 
>> enough with the code to review those.
>
> Thank you. Sorry for being ignorant, but what is the way forward?

Well, that's a very valid question. The general approach is that driver 
changes are pushed upstream through the driver maintainers tree.

Since this driver change depends on a change in the general kernel an rb 
from somebody who feels responsible for the code in the general kernel 
might be a good idea.

But since you already addressed Linus comments and it looks rather clean 
I think I can just push it to drm-misc-next on Monday if nobody objects 
over the weekend.

Thanks for the help,
Christian.

>
>
> Kind regards,
>
> Paul