From: Paolo Bonzini <pbonzini@redhat.com>
To: Maxim Levitsky <mlevitsk@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: work around QEMU issue with synthetic CPUID leaves
Date: Sun, 1 May 2022 19:37:02 +0200 [thread overview]
Message-ID: <54adc4a3-6b66-8ddf-db92-9630089da2dd@redhat.com> (raw)
In-Reply-To: <1dcfb3d243916a3957d5368c2298e3f8fd79a9f2.camel@redhat.com>
On 5/1/22 13:16, Maxim Levitsky wrote:
>> + * However, only do it if the host has CPUID leaf 0x8000001d.
>> + * QEMU thinks that it can query the host blindly for that
>> + * CPUID leaf if KVM reports that it supports 0x8000001d or
>> + * above. The processor merrily returns values from the
>> + * highest Intel leaf which QEMU tries to use as the guest's
>> + * 0x8000001d. Even worse, this can result in an infinite
>> + * loop if said highest leaf has no subleaves indexed by ECX.
>
> Very small nitpick: It might be useful to add a note that qemu does this only for the
> leaf 0x8000001d.
Yes, it's there: "QEMU thinks that it can query the host blindly for
that CPUID leaf", "that" is 0x8000001d in the previous sentence.
Paolo
next prev parent reply other threads:[~2022-05-01 17:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 19:25 Paolo Bonzini
2022-05-01 11:16 ` Maxim Levitsky
2022-05-01 17:37 ` Paolo Bonzini [this message]
2022-05-02 6:25 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54adc4a3-6b66-8ddf-db92-9630089da2dd@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlevitsk@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®