From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA4683E1230 for ; Tue, 24 Mar 2026 10:13:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774347234; cv=none; b=Ty1tY6MSZBzPpCVIYG69D6ovqRsuITW4xcLwv9aYcgcYnAFWHcT+KxHepUog8T50wnSPZSX/vl0BPjZFTgFbePqfFUiVL1eKKhgJrkW/D76E9mex1Ypvx7Z16Wmbq+qFAG6G/vqlLbiosrPZ3VJWiNvuqLb5/WgeQD6HIz2cCO4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774347234; c=relaxed/simple; bh=oZQF5zkmi/jYghxQhGl6dRp9MvI1QQwb/XVLSRsXzoY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nGlStsbFB9nfuu+lZAcRp91d0tgQNuXvi5+0A+z14Un5Wf2ssj372LKWefx20EPop8oPrirmqFrwovHmF/ovmjTSbRlRVX/J5Uj69LUYmK0FBF3+uOgnK9JSFpG5mQZZkbCtP9aD67CT8GvGsDi47mVoK+K+CcNpmHQ3ocuwY3s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UeQqaI2y; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OEhCbgdR; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UeQqaI2y"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OEhCbgdR" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62O9wa123039807 for ; Tue, 24 Mar 2026 10:13:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= pF5Yvft9OWQEMcww/FMusyd7xCYp7Y1/Nvsmv+Coe/0=; b=UeQqaI2y1Zd337qL QuVcHXzz9P0SMm00hLDKPksIxo9rRO+1lBcb1dyX90oaJlQaR5gLciok6t4kSP3M bK+ZOMCCG6Bv77b/Lp/ob/H2t4hVXVXcAHQnLyyHInOj4GmeeiyfqbsBnE8q+nZs UvrJypLjy4/xK3LghAqbQs6tdhEz6mrVuCe/TruaOpnWEsh/CVmLLPej1UOtgReD YI2mozRSFxRPGFE3X+2+U27gIV1Ss5hZPIDeoyU3cHAMJcTIXefg0NlSVpJa4CId eaSDz9d741EuyiqV8g05AkgCJMTEqlxilpWlhLia7zSh+egHFnj+WI95vQzVVn9c G21qSw== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d3rf0g29t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 24 Mar 2026 10:13:49 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-89c49436edeso43516176d6.0 for ; Tue, 24 Mar 2026 03:13:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774347229; x=1774952029; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pF5Yvft9OWQEMcww/FMusyd7xCYp7Y1/Nvsmv+Coe/0=; b=OEhCbgdRgX8GgtBLmUHmIuPBsNG/RXntF4SDOsqmZJ9+TUyWuo6nnynIuAZLatQNHW nm9lt4N2ZlTF7zL+AAHR9H5CIroIozEqwVcL65XKDito59TQUqaMO5QpB6lY6RzCekor 8VFaLBSBvsJUzlBpdzGTboF5sHAq1K/QvS9Asz4+ZP7KrMU7Nj052hknrOyvro92b4TG OF5E8bROl14Ik43VoMYVoYrWjoZwjn4P6T1njpE5BwwBH3UCaTQu1B8CDqeeJlLTDT2N oY2hRFvAyTGvUIsOPfXH9d1ZnPSSZZbQWGHub3WoWgkfmJXblfLJrFO5R9VNX6rdk+fJ TT5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774347229; x=1774952029; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pF5Yvft9OWQEMcww/FMusyd7xCYp7Y1/Nvsmv+Coe/0=; b=nj1b5txmFWx5vVW5NskrPPvrJuPXtI95fkFbCS0VdEyUw3UkVS7CA7NZFOOviHc1Ug 0ogZ7bCnwzD7hPVfXmpCLmkEi1BpLseW2WOMXryOI16xrh4kVnED6SqGQ969/e6yqCsp 5VOlOXwOVBIuxWw6ICgm8BbmceSN5/JS+4/Nl8MBlSDQ2Ey9BDhMz7GzKUNvTNZOrClm AJz+XJJ1P7KIYzlWWBvyKEuSRsSaTY9VHO7uKqMmEyfi3fQY9ElUG2PZVVgJsOOuCCMd WFED6HVanO9dtTyW67Ash5/ugsPeMNe/NPOU5nlzmtLtIM49WbmfujeF6RbgyJ/rl3Dk Rw2w== X-Forwarded-Encrypted: i=1; AJvYcCXXaIeMoFesPwGNze5qGds6t5BDdX0hG5GO9XrHFK2MT+7XhGBxziOrwCrSNAEY0tIRoACcJ/CDwTaZvMk=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1xKMrInwueAydAYk7ug+jslzap5kaExbZZ5dq/cTeF0EL/wwI PzdXR6QJUOvjkTBBDY/c8m04xzhY3pwtLax7HjJsVnhu2nOQjq5V2FrATVEFp+YvlYjpaHezIPg 7S0fIhA3m6UhFfErSaPt/dgPO+BDaY0c0b1uWo5K9rnmxDDEGk4NXXSqiM5n/BggnkcU= X-Gm-Gg: ATEYQzwiR7snJxOYq3pCu3UURIDI8DwZows4LGnuq5zaXpKdGCcHYyJwvCKfV+SJy2b wfhq6NqQq7bSFBXRDjdDW59491STUTXIfcgyR+P53mbFiVlxcfHX+BC0Uqh2VS9dj902Mc2gS2E ljymnaIUIydT40Dt4fkOuaeN82yTiCYjVl+2no/Vgke5FjvgGakTrBu3XQI+gOpppuOiJ3hwanQ MB/CO4DQm4HwaW6U2E+NJ4BBynkHaVnthSJrvsfyr5cl7K6ji9dOv/eG3KwHF6CKbILjTpB97PI J8+j4BAjmm//ex3Wq4MpBVo/EEuNj0rsAcdU6MfidwQVKaXT14aF33rmzPBQKDKwsEIVJSeIc93 yfgso+KSJms5OLPBszy5kcNh3ufqkqsMtI3dGysQJz0pvkTScWgLIsszGTZFqrXwpnZ4gzoHOJl kxZlw= X-Received: by 2002:a05:6214:62d:b0:89a:4fd5:6998 with SMTP id 6a1803df08f44-89c859d79f3mr191654276d6.1.1774347228574; Tue, 24 Mar 2026 03:13:48 -0700 (PDT) X-Received: by 2002:a05:6214:62d:b0:89a:4fd5:6998 with SMTP id 6a1803df08f44-89c859d79f3mr191654006d6.1.1774347228179; Tue, 24 Mar 2026 03:13:48 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b983387084asm619569266b.53.2026.03.24.03.13.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Mar 2026 03:13:46 -0700 (PDT) Message-ID: <54b03221-d21b-4582-b0b9-d2384480356b@oss.qualcomm.com> Date: Tue, 24 Mar 2026 11:13:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 13/16] drm/msm/a8xx: Implement IFPC support for A840 To: Akhil P Oommen , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco , Connor Abbott , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260324-a8xx-gpu-batch2-v1-0-fc95b8d9c017@oss.qualcomm.com> <20260324-a8xx-gpu-batch2-v1-13-fc95b8d9c017@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260324-a8xx-gpu-batch2-v1-13-fc95b8d9c017@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI0MDA4MSBTYWx0ZWRfX67QZhGvhbCpj Fu9TqDifm+G8v1pdnN6ZMJE4ycCMBjMq7L/noP9OflZVHUi9FCOuwpv8EVGlxD+lBbMv5e0dhtE gZX21a9MB6U8tTy6h17/lrk4XmsmiPicpcktBE4FonBgc5s+lZZ1A6coNgNFLMyE9NeRdy8X/bS iXaVv2v85c4aCmAqcYwSz/9c3l0LN+fduJVjFCt/blF5DzXIr1u396O5EmNByLMkEaKSYEf9+ql rq7LJXID/Rxd6zgKkZmL1fn/WJNtRKAAQ3MvLWpCn5b8kkF9HpSKz6cfu/KfZtwD0kMsTn/wE77 8O58WH59f8Jramg8O6ryZ5gqk+4zgrO7VZdjlkoShCyOvbYBF/S8zL+q61bwyQZUn3jjLSQ66ZA A2+FhTL6ECQfOACxBlGc3rA8pqGdh+yY3mHXDgdCuZs3gB50u0YxkBkW3kRDsa898bJhRK788FN WbZ0wzvyTQgP0E22LyQ== X-Authority-Analysis: v=2.4 cv=Ua9ciaSN c=1 sm=1 tr=0 ts=69c263dd cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=4f25mLXvg3xlTH-B0vkA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-ORIG-GUID: ZlGi7rmcZ3w1P1QR0LHrXdtGwGIssLsB X-Proofpoint-GUID: ZlGi7rmcZ3w1P1QR0LHrXdtGwGIssLsB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-24_02,2026-03-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0 clxscore=1015 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603240081 On 3/23/26 9:12 PM, Akhil P Oommen wrote: > Implement pwrup reglist support and add the necessary register > configurations to enable IFPC support on A840 > > Signed-off-by: Akhil P Oommen > --- [...] > + for (u32 pipe_id = PIPE_BR; pipe_id <= PIPE_DDE_BV; pipe_id++) { > + for (i = 0; i < dyn_pwrup_reglist->count; i++) { > + if ((dyn_pwrup_reglist->regs[i].pipe & BIT(pipe_id)) == 0) that's a nitty pet peeve, but I'd check for if (!(...)) instead [...] > + continue; > + *dest++ = A8XX_CP_APERTURE_CNTL_HOST_PIPEID(pipe_id); > + *dest++ = dyn_pwrup_reglist->regs[i].offset; > + *dest++ = a8xx_read_pipe_slice(gpu, > + pipe_id, > + a8xx_get_first_slice(a6xx_gpu), Only the first slice? [...] > + /* Lo address */ > + OUT_RING(ring, lower_32_bits(a6xx_gpu->pwrup_reglist_iova)); > + /* Hi address */ > + OUT_RING(ring, upper_32_bits(a6xx_gpu->pwrup_reglist_iova)); > + > + /* Enable dyn pwrup list with triplets (offset, value, pipe) */ > + OUT_RING(ring, BIT(31)); I believe you need to patch OUT_PKT7() with the updated cmd count Konrad