From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756179AbeARNRH (ORCPT ); Thu, 18 Jan 2018 08:17:07 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:38497 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756028AbeARNRF (ORCPT ); Thu, 18 Jan 2018 08:17:05 -0500 Subject: Re: [PATCH] can: m_can: mark runtime-PM handlers as __maybe_unused To: Arnd Bergmann , Wolfgang Grandegger Cc: Mario Huettel , Faiz Abbas , Oliver Hartkopp , Quentin Schulz , Franklin S Cooper Jr , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180118130513.506569-1-arnd@arndb.de> From: Marc Kleine-Budde Message-ID: <54b08b88-493f-a39e-db00-194ba91dcedf@pengutronix.de> Date: Thu, 18 Jan 2018 14:16:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20180118130513.506569-1-arnd@arndb.de> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="QsoqBId3iOzhTL4wJEBBVEJNArre4yqYv" X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QsoqBId3iOzhTL4wJEBBVEJNArre4yqYv Content-Type: multipart/mixed; boundary="7NirtgnNqJA2XJZe6PpVrbzWvFiL1WfUB"; protected-headers="v1" From: Marc Kleine-Budde To: Arnd Bergmann , Wolfgang Grandegger Cc: Mario Huettel , Faiz Abbas , Oliver Hartkopp , Quentin Schulz , Franklin S Cooper Jr , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <54b08b88-493f-a39e-db00-194ba91dcedf@pengutronix.de> Subject: Re: [PATCH] can: m_can: mark runtime-PM handlers as __maybe_unused References: <20180118130513.506569-1-arnd@arndb.de> In-Reply-To: <20180118130513.506569-1-arnd@arndb.de> --7NirtgnNqJA2XJZe6PpVrbzWvFiL1WfUB Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: quoted-printable On 01/18/2018 02:04 PM, Arnd Bergmann wrote: > Building without CONFIG_PM results in a harmless warning: >=20 > drivers/net/can/m_can/m_can.c:1763:12: error: 'm_can_runtime_resume' de= fined but not used [-Werror=3Dunused-function] > drivers/net/can/m_can/m_can.c:1752:12: error: 'm_can_runtime_suspend' d= efined but not used [-Werror=3Dunused-function] >=20 > Marking the functions as __maybe_unused lets the compiler > silently drop them instead. >=20 > Fixes: cdf8259d6573 ("can: m_can: Add PM Support") > Signed-off-by: Arnd Bergmann Tnx - applied. However all archs using this driver have mandatory PM support and the driver depends on it. Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --7NirtgnNqJA2XJZe6PpVrbzWvFiL1WfUB-- --QsoqBId3iOzhTL4wJEBBVEJNArre4yqYv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEE4bay/IylYqM/npjQHv7KIOw4HPYFAlpgnjUACgkQHv7KIOw4 HPZJEgf/cm/hMOFlCr4NTbfn2Wtol4AKxUVBxfIiP2+0KJXgOsNUrS44GWoO1kuO Fr/BEf+rXsVg/ev74GhE4nPrab09OgZQfzdbRe4LjCG1lwA0en4XlYXYiIrtbH2w DDmdu+9ZwBYNxmz6iE19lti0l+HAt+BMmJk2bL+mS2NFtjTyg7QOGYkCsGjPnbJH O1GwPwI9uMbUGDHTglvNWyo6nzcpwBi2OM246Ko7oiabrH+AtsPSmVk6SIVgj4R8 0dunRZY9jH+q1Y0mKAYvKh7Czo0Zpej1jRyqAKNuo7ygW8xIOD1s8UVFjjWS9i1W 7Tw/JstkCwGd/ZyfTguaDMdl347Nhw== =22xJ -----END PGP SIGNATURE----- --QsoqBId3iOzhTL4wJEBBVEJNArre4yqYv--