From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FCC0246766 for ; Thu, 16 Apr 2026 04:22:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776313350; cv=none; b=O5cA/hEPPBEg9bJS7zl/ulEgn8rtAPlGzl3Oxp8VQKEqtr4IF5LtNgiPCTIQ1Ybpkxu8Lc1nwnKPp0e5wy90cvCMD28RTnOrJfj7tc+llHXIKroIZEs8NenUDuMd6chRP9ekoF4R9F5jYQ757alXb7UIWu4vUKEKo3kdgTtW71E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776313350; c=relaxed/simple; bh=cC4WkBkhIV6zQcr6G+XqJeZSC5/dcGe9OmI2zlbAVMg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BqbupNlNAzdI+6CQmxxZLK0s0Wz10gLZJYEEJg2dE26jjBGKQYWz/5+6RX7ks9hDHI//eTJZz99rP5DC2mffRQU4MpVLYZBUAh9emcLrIYNw5JvK+L7c4d6TfylQywX8KgNGvP0OGRZnACzwwDrX2bfo8M2neZ5+y5ZzrAArYjI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=bksPd80P; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="bksPd80P" Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63FK8m872487108; Thu, 16 Apr 2026 04:22:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=UbjDTF CafDYMJbsKLc4sKLOMaexnyfa/MqYdYKYXm3M=; b=bksPd80P8cmHnJ6vMl2Tsr GZ1fG3a3lwOXp7N+7XIy9P73erVl2BSYWKBsBoURE78ozAZGecpM7ODMq0fCNjtA +XnrJH6XCiUOx2auafbgsylyGlRuqPokHr7ITXwIy/3nAX2ySkCHBBpujzl91fyY sdSm5ehRP3uwTLL36GdajmczUkF99ITen+CU7f8iLMqn+C+iVKHE96UiHtJN30zM 3g+qE2mxHqZe1UJ8wSRzoQS2Jh6LTFgqZ0kWe1XBXyQJrtCaLOGyfJD3ed1iC451 GSYY3scRgh3UXueAmekeTt0j1PlJZcne1DLeLaWWXPTf3eAATojoTGRKZQrhb+mQ == Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dh89mauhm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 16 Apr 2026 04:22:18 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 63G0aHo4015164; Thu, 16 Apr 2026 04:22:17 GMT Received: from smtprelay06.dal12v.mail.ibm.com ([172.16.1.8]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 4dg0mssgcp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 16 Apr 2026 04:22:17 +0000 Received: from smtpav06.dal12v.mail.ibm.com (smtpav06.dal12v.mail.ibm.com [10.241.53.105]) by smtprelay06.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 63G4MGjU33620538 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 16 Apr 2026 04:22:16 GMT Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C7B7458055; Thu, 16 Apr 2026 04:22:16 +0000 (GMT) Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2C9D058043; Thu, 16 Apr 2026 04:22:13 +0000 (GMT) Received: from [9.39.27.85] (unknown [9.39.27.85]) by smtpav06.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 16 Apr 2026 04:22:12 +0000 (GMT) Message-ID: <54b0f31f-6720-4e39-a182-ba11948cb024@linux.ibm.com> Date: Thu, 16 Apr 2026 09:52:11 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/page_alloc: fix spaces used for indentation instead of tabs To: Xiang Gao , akpm@linux-foundation.org, vbabka@kernel.org Cc: surenb@google.com, mhocko@suse.com, jackmanb@google.com, hannes@cmpxchg.org, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiang Gao References: <20260416021945.682234-1-gxxa03070307@gmail.com> Content-Language: en-US From: Donet Tom In-Reply-To: <20260416021945.682234-1-gxxa03070307@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Authority-Analysis: v=2.4 cv=I/dVgtgg c=1 sm=1 tr=0 ts=69e063fa cx=c_pps a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=IeNN-m2dAAAA:8 a=1azo6HzM0BMiu3SuvnMA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: epCRGs4vnWPIgG8-ZtT0ohZs1Bx2acYi X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE2MDAzOCBTYWx0ZWRfX0Xg/xp8qXUAM nF9H3XYipk1IawCIwlh8eIXLbBem/XetLBGlnEHtR5J0s1bcddD5CRZY4r+m6bpE9uqMyLj0wIk nishbjouVaQycm6FIKu0IiEGIn0vpoj7d6dEWGg9zAYzLIzdgO7x+P5BFAFjBR9r+nvmm/PKUCE EIOfVvhBekF5Et60bppYz+spc2hrdmNw6iDkOO6hWZYW0WgDXUX5monD/Kzecf3nLHRQoOHpIXB oErUPa9s78JFf2sdXu3Ly4frCZVpGAy+Jks53DXq4wXnGwBjzE9/qzvggJyw9fRs9ZvhRhwoWRB uJq7VMyKRsQeGX49cDCh/VbLqDynA/0iDajzYKW3xaH9sVbEGge3+lFlYKZSUuyVeJJTjwRyNAs 3auiv/EhB657daxKZS8PA45v5f76515v2gtxGeYxhTy0TFabfCLBp/mezN5LLh8ABCA5dR3pfNw YZzX7Ov6AmUIpx/qTwQ== X-Proofpoint-ORIG-GUID: M9nBvpOhQkEOfsEYgUM1n95gPL1rsio- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-16_01,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 phishscore=0 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604160038 Hi On 4/16/26 7:49 AM, Xiang Gao wrote: > From: Xiang Gao > > checkpatch.pl reports two indentation errors in page_alloc.c where > spaces are used instead of tabs: > > ERROR: code indent should use tabs where possible > #887: FILE: mm/page_alloc.c:887: > + VM_WARN_ONCE(get_pageblock_migratetype(page) != migratetype,$ > > ERROR: code indent should use tabs where possible > #6626: FILE: mm/page_alloc.c:6626: > + sysctl_min_unmapped_ratio) / 100;$ > > In __del_page_from_free_list(), the VM_WARN_ONCE at line 887 uses 8 > spaces for indentation instead of a tab. The identical VM_WARN_ONCE > calls in __add_to_free_list() and move_to_free_list() both correctly > use a tab. > > In setup_min_unmapped_ratio(), the continuation line at 6626 uses 6 > tabs + 9 spaces for alignment. Replace the excess spaces with 6 tabs > + 1 space to correctly align with the opening parenthesis on the > previous line. > > Signed-off-by: gaoxiang17 > I am seeing below issue with checkpatch.pl ./scripts/checkpatch.pl --strict 0001-mm-page_alloc-fix-spaces-used-for-indentation-instea.patch WARNING: From:/Signed-off-by: email name mismatch: 'From: Xiang Gao ' != 'Signed-off-by: gaoxiang17 ' -Donet > --- > mm/page_alloc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 2d4b6f1a554e..752673a9b43c 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -884,7 +884,7 @@ static inline void __del_page_from_free_list(struct page *page, struct zone *zon > { > int nr_pages = 1 << order; > > - VM_WARN_ONCE(get_pageblock_migratetype(page) != migratetype, > + VM_WARN_ONCE(get_pageblock_migratetype(page) != migratetype, > "page type is %d, passed migratetype is %d (nr=%d)\n", > get_pageblock_migratetype(page), migratetype, nr_pages); > > @@ -6623,7 +6623,7 @@ static void setup_min_unmapped_ratio(void) > > for_each_zone(zone) > zone->zone_pgdat->min_unmapped_pages += (zone_managed_pages(zone) * > - sysctl_min_unmapped_ratio) / 100; > + sysctl_min_unmapped_ratio) / 100; > } > >