mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sumit Gupta <sumitg@nvidia.com>
To: Jiri Benc <jbenc@redhat.com>
Cc: rafael@kernel.org, viresh.kumar@linaro.org,
	pierre.gondois@arm.com, ionela.voinescu@arm.com,
	zhenglifeng1@huawei.com, zhanjie9@hisilicon.com, corbet@lwn.net,
	skhan@linuxfoundation.org, rdunlap@infradead.org,
	mario.limonciello@amd.com, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-tegra@vger.kernel.org, treding@nvidia.com,
	jonathanh@nvidia.com, vsethi@nvidia.com, ksitaraman@nvidia.com,
	sanjayc@nvidia.com, mochs@nvidia.com, bbasu@nvidia.com
Subject: Re: [PATCH v5 1/2] cpufreq: CPPC: Set CPPC Enable register in cpu_init
Date: Thu, 5 Nov 2026 18:07:16 +0530	[thread overview]
Message-ID: <54b3291a-f557-45c9-a963-4023e739e059@nvidia.com> (raw)
In-Reply-To: <20261105105106.23238599@jbenc-thinkpadp1gen4i.rmtcz.csb>



On 05/11/26 15:21, Jiri Benc wrote:
> External email: Use caution opening links or attachments
> 
> 
> On Tue, 23 Jun 2026 13:36:51 +0530, Sumit Gupta wrote:
>> As per ACPI 6.x s8.4.6.1.4 (CPPC Enable register):
>>    "If supported by the platform, OSPM writes a one to this register
>>     to enable CPPC on this processor. If not implemented, OSPM assumes
>>     the platform always has CPPC enabled."
>>
>> Call cppc_set_enable() at the start of cppc_cpufreq_cpu_init() so
>> this is done for both OS-driven and autonomous CPPC control modes.
>> Errors are logged but non-fatal as the register is optional.
> 
> Sumit, given this is a bug fix to the CPPC driver (e.g. NVIDIA GB10
> doesn't enable CPPC without writing the register, keeping the CPUs
> always at the lowest freq) and is largely unrelated to the autonomous
> mode feature, could you please resubmit this as a standalone patch?
> 
> Thanks!
> 
>   Jiri
> 

Posted separately.

https://lore.kernel.org/lkml/20261105123244.3132560-1-sumitg@nvidia.com/

Thanks,
Sumit


>> Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
>> ---
>>   drivers/cpufreq/cppc_cpufreq.c | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
>> index f6cea0c54dd9..f7a47576717a 100644
>> --- a/drivers/cpufreq/cppc_cpufreq.c
>> +++ b/drivers/cpufreq/cppc_cpufreq.c
>> @@ -655,6 +655,14 @@ static int cppc_cpufreq_cpu_init(struct cpufreq_policy *policy)
>>        caps = &cpu_data->perf_caps;
>>        policy->driver_data = cpu_data;
>>
>> +     /*
>> +      * Enable CPPC for both OS-driven and autonomous modes.
>> +      * The Enable register is optional - some platforms may not support it
>> +      */
>> +     ret = cppc_set_enable(cpu, true);
>> +     if (ret && ret != -EOPNOTSUPP)
>> +             pr_warn("Failed to enable CPPC for CPU%d (%d)\n", cpu, ret);
>> +
>>        /*
>>         * Set min to lowest nonlinear perf to avoid any efficiency penalty (see
>>         * Section 8.4.7.1.1.5 of ACPI 6.1 spec)
> 


  reply	other threads:[~2026-11-05 12:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-23  8:06 [PATCH v5 0/2] cpufreq: CPPC: add autonomous mode boot parameter support Sumit Gupta
2026-06-23  8:06 ` [PATCH v5 1/2] cpufreq: CPPC: Set CPPC Enable register in cpu_init Sumit Gupta
2026-11-05  9:51   ` Jiri Benc
2026-11-05 12:37     ` Sumit Gupta [this message]
2026-06-23  8:06 ` [PATCH v5 2/2] cpufreq: CPPC: add autonomous mode boot parameter support Sumit Gupta
2026-07-01 16:24   ` Pierre Gondois
2026-07-09 17:38     ` Sumit Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54b3291a-f557-45c9-a963-4023e739e059@nvidia.com \
    --to=sumitg@nvidia.com \
    --cc=bbasu@nvidia.com \
    --cc=corbet@lwn.net \
    --cc=ionela.voinescu@arm.com \
    --cc=jbenc@redhat.com \
    --cc=jonathanh@nvidia.com \
    --cc=ksitaraman@nvidia.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=mochs@nvidia.com \
    --cc=pierre.gondois@arm.com \
    --cc=rafael@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=sanjayc@nvidia.com \
    --cc=skhan@linuxfoundation.org \
    --cc=treding@nvidia.com \
    --cc=viresh.kumar@linaro.org \
    --cc=vsethi@nvidia.com \
    --cc=zhanjie9@hisilicon.com \
    --cc=zhenglifeng1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®