From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF640C0015E for ; Thu, 13 Jul 2023 09:46:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233436AbjGMJqM (ORCPT ); Thu, 13 Jul 2023 05:46:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233040AbjGMJpx (ORCPT ); Thu, 13 Jul 2023 05:45:53 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0226D2D43 for ; Thu, 13 Jul 2023 02:43:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689241429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uvl5g0I3V6gIRknYTzW98aMpTqLnXVAL5Iexw4g15cg=; b=eu/WssOYo4QhchEutCqd4dgWdzN4Y2SNii/n0GTP7rgXSNEs9W+G/rlH+V6a8a00pJrV/2 wIoetnxGirdAJE3j+gND514G3kpyqz9MSVfVcDvLklTMvXydvABH+ZGr3gPKr38wBP43kQ kbuqWiR4ipKxOU1s/kr4tLGVdfzJfqc= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-479-gVK6myUfPxiFmLIRbcfbmQ-1; Thu, 13 Jul 2023 05:43:48 -0400 X-MC-Unique: gVK6myUfPxiFmLIRbcfbmQ-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-767ca6391aeso12738485a.1 for ; Thu, 13 Jul 2023 02:43:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689241427; x=1691833427; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=uvl5g0I3V6gIRknYTzW98aMpTqLnXVAL5Iexw4g15cg=; b=HxASqCm3UgNOLe6KDIQ+SHPXH8tJvloiDqWMoDEK9bA4GTRQWWprUqyAEEPVfyyd9K GP9qyr4IxxErsdAXileIcj9qcIssT7yT3aMDMnKkj+Gb4wCps1MEGjQoK346WZjPj/qa CZcjdLawM1lJz71viKSK5szwvLu/zjnyqDW71QfrPsKi6XexHycsfoo0qKznKIea+7nh VU2uF8XqEUJx2cmT6hrbNPzGUNPIi4ZMi/LgOjs/wLT1Wpd+R81vfkf6hAp+EJyjDbsl Y441cpPbVbcXrHj0RlLUHfWhrlUsIcvAk1RtppYVWFbfoJv3ZsP09Xz8SDy3fh1sXZdC 1+QQ== X-Gm-Message-State: ABy/qLZ4CnYAqLO2p9ynNhF3uNkOC053xbZ54mYN26gtMXpU1Zp6OJ6c RClW3IyJM8Ng4tCMS/HLm0NMYRXM8JeTGjwGu8qd7/8QJD+fZi4dCaTPfLxwwTIkfwNprlNQB7p xXYXO7Id+ohqFP4puLA9W6858p/7gH5Ja X-Received: by 2002:a05:620a:471e:b0:767:13cd:e17d with SMTP id bs30-20020a05620a471e00b0076713cde17dmr1160191qkb.3.1689241427619; Thu, 13 Jul 2023 02:43:47 -0700 (PDT) X-Google-Smtp-Source: APBJJlHPetQa7l02yWfkaCDia2vEYnlURmsCxd3pHlY3W0FYEdJ+SRTXZNHsUrEF9ekvUKtT2nPDtg== X-Received: by 2002:a05:620a:471e:b0:767:13cd:e17d with SMTP id bs30-20020a05620a471e00b0076713cde17dmr1160182qkb.3.1689241427405; Thu, 13 Jul 2023 02:43:47 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-235-188.dyn.eolo.it. [146.241.235.188]) by smtp.gmail.com with ESMTPSA id g5-20020a37e205000000b00767cee76155sm2743794qki.55.2023.07.13.02.43.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jul 2023 02:43:47 -0700 (PDT) Message-ID: <54b3fb4d5a58d123826a7f0c8442379dc071dfcc.camel@redhat.com> Subject: Re: =?UTF-8?Q?=E5=9B=9E=E5=A4=8D=3A?= [PATCH net v1] ath6kl:Fix error checking for debugfs_create_dir() From: Paolo Abeni To: =?UTF-8?Q?=E7=8E=8B=E6=98=8E-=E8=BD=AF=E4=BB=B6=E5=BA=95=E5=B1=82?= =?UTF-8?Q?=E6=8A=80=E6=9C=AF=E9=83=A8?= Cc: Kalle Valo , "linux-wireless@vger.kernel.org" , LKML , "opensource.kernel" Date: Thu, 13 Jul 2023 11:43:44 +0200 In-Reply-To: References: <20230713040518.13734-1-machel@vivo.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2023-07-13 at 09:31 +0000, =E7=8E=8B=E6=98=8E-=E8=BD=AF=E4=BB=B6=E5= =BA=95=E5=B1=82=E6=8A=80=E6=9C=AF=E9=83=A8 wrote: > Thank you for pointing out, I will pay attention to it in the future. > In addition, do I need to modify this patch and submit it again? Yes, a v2 is needed.=20 There are a few patches on this same topic, and I read only now what Simon noted: https://lore.kernel.org/linux-wireless/ZG8YY%2Fr8BLCzw93q@corigine.com/ so, the current code is likely not really buggy, and a possible cleanup patch (such patch would _not_ be a fix) could simply remove the check altogether. Cheers, Paolo