From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABA83CE7A95 for ; Mon, 25 Sep 2023 09:28:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233201AbjIYJ3B (ORCPT ); Mon, 25 Sep 2023 05:29:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230429AbjIYJ26 (ORCPT ); Mon, 25 Sep 2023 05:28:58 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4ABE0AB for ; Mon, 25 Sep 2023 02:28:52 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-50336768615so10094983e87.0 for ; Mon, 25 Sep 2023 02:28:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695634130; x=1696238930; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/ZX92zrxOAca8I4MUvhs72zkp2YfHpvrQUJ9Dpjq+9E=; b=JJBBa0nIyU8sFGiYiaug/jtHc6oPesTZ78LEkAqSGjdNKJlGPLrPpedxnds4fffzWL ixemWkVJt8HEf+yDi6Yl1Sa4054TRMQG56qogwvZPexqd7g+H4SKwMbPOLMRoptFuJzU cBwPQLzS+IlXtbTIbXb7i2XgNA4q7NYJ/do3v+iNOamj7PwmTqqJNzGnBVIGUAtm66a7 JjuyFRNos1RQNxact3y2/HAlW9RgHzGlxh/AOPtUQIGTm9wISPLJsL3EHCuWqdB4a5Ye 7bURcs9spnnGg3tZnZBwoI9di4OcrH850IPAk0ogDZwJCOn7hayB4mAHG1JicBRHBqN6 Lsew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695634130; x=1696238930; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/ZX92zrxOAca8I4MUvhs72zkp2YfHpvrQUJ9Dpjq+9E=; b=BBiVClN3nBb3FqfE8NicgtMpOyNM8377JeynrQHr6COf57JPWkh0ZYJj5CA9FFu2S8 sJlWJflLwXfl2pFmDhdrMwN7GQaqm7EXBlXqiw4v3C9UWO7fxH6vjYju7zdRm0oHVddy UYxbarBP7enuQ63ILZAp7Ui0ypB4SEPZLBP1ncQ1fT68Qa3MXOgu8+ngxn6h4zAN+cG2 cgm72YnpKr2HMOB1MYjskY1d4MaC6Z/cL8IR2uOl7mmyqxzWHvEXfQB9uVrYCVJ3F8jg lN9KUhhtybqFS7afa8jXaJXXgWDsGm729VoaO+AtCbWFo2LXccJ9NB5wbe6bMIhN1NWk Qhaw== X-Gm-Message-State: AOJu0Yze9k+aKlPWYX3WtmN4FxmErfKvip7A5+JOOtrW8hyhia+7yx1P 89x++R4JmHzyGtjj9OkAJySPWg== X-Google-Smtp-Source: AGHT+IG3JZMmhl/6oEoRU+xXDgoaN8B1E/0y3dFe2ICahNie1gDc7iugLncaIWYPulRNn6Cctymrxw== X-Received: by 2002:a19:f508:0:b0:503:3781:ac32 with SMTP id j8-20020a19f508000000b005033781ac32mr5022463lfb.41.1695634130511; Mon, 25 Sep 2023 02:28:50 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.100]) by smtp.gmail.com with ESMTPSA id n2-20020aa7c442000000b0052e1959db1csm5260040edr.20.2023.09.25.02.28.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Sep 2023 02:28:49 -0700 (PDT) Message-ID: <54b6ee93-1d36-46a4-a104-59129fe41a32@linaro.org> Date: Mon, 25 Sep 2023 11:28:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/15] dt-bindings: gce: mt8195: Add CMDQ_SYNC_TOKEN_SECURE_THR_EOF event id Content-Language: en-US To: =?UTF-8?B?SmFzb24tSkggTGluICjmnpfnnb/npaUp?= , "jassisinghbrar@gmail.com" , "matthias.bgg@gmail.com" , "chunkuang.hu@kernel.org" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "angelogioacchino.delregno@collabora.com" Cc: "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , =?UTF-8?B?U2luZ28gQ2hhbmcgKOW8teiIiOWciyk=?= , =?UTF-8?B?Sm9obnNvbiBXYW5nICjnjovogZbpkasp?= , =?UTF-8?B?SmFzb24tY2ggQ2hlbiAo6Zmz5bu66LGqKQ==?= , "devicetree@vger.kernel.org" , =?UTF-8?B?U2hhd24gU3VuZyAo5a6L5a2d6KyZKQ==?= , =?UTF-8?B?TmFuY3kgTGluICjmnpfmrKPonqIp?= , "conor+dt@kernel.org" , "dri-devel@lists.freedesktop.org" , =?UTF-8?B?RWx2aXMgV2FuZyAo546L5YabKQ==?= , "linux-arm-kernel@lists.infradead.org" , Project_Global_Chrome_Upstream_Group References: <20230918192204.32263-1-jason-jh.lin@mediatek.com> <20230918192204.32263-3-jason-jh.lin@mediatek.com> <20372e40-e4fc-467a-d91a-fcf8e26728bc@linaro.org> <1f324b04cbd8faa7510a3519eb718c0be25af2be.camel@mediatek.com> <354bb70cd3f1921dd58629a044af7bfe4f3306c0.camel@mediatek.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <354bb70cd3f1921dd58629a044af7bfe4f3306c0.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/09/2023 11:11, Jason-JH Lin (林睿祥) wrote: > On Mon, 2023-09-25 at 08:42 +0200, Krzysztof Kozlowski wrote: >> >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> On 25/09/2023 07:05, Jason-JH Lin (林睿祥) wrote: >>> Hi Krzysztof, >>> >>> Thanks for the reviews. >>> >>> On Sat, 2023-09-23 at 20:01 +0200, Krzysztof Kozlowski wrote: >>>> >>>> External email : Please do not click links or open attachments >> until >>>> you have verified the sender or the content. >>>> On 18/09/2023 21:21, Jason-JH.Lin wrote: >>>>> CMDQ_SYNC_TOKEN_SECURE_THR_EOF is used as secure irq to notify >> CMDQ >>>>> driver in the normal world that GCE secure thread has completed a >>>> task >>>>> in thee secure world. >>>> >>>> How can #define be added after its usage? Does it even make any >> sense >>>> of >>>> being separate patch? >>>> >>> >>> This definition is used in the mt8195.dts at [PATCH 15/15] and the >> CMDQ >> >> No, the define is used in previous patch, which means your patchset >> is >> not bisectable and not tested. >> > > Do you mean this patch should add before patch 1? > > > The example of dts in patch 1 is used the definition of mt8188, so I > think I can add this patch to define the gce event id for mt8195 after > patch 1. > > I will swap the patch 1 and the patch 2 in the next version, if that > can make it more appropriate. Really, test your patches. Each of them individually. Appropriateness is one thing, but broken bisectability is an error. Anyway, the patch is logically part of binding adding this, so it should be squashed. Don't create some weird patch ordering where every define or every function is in its own patch. I commented about it multiple times in this patchset. Best regards, Krzysztof