From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-188.mta1.migadu.com (out-188.mta1.migadu.com [95.215.58.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96995196DB1 for ; Tue, 29 Oct 2024 16:17:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.188 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730218645; cv=none; b=PAJcnc5FlLRdJ6B8HT3vk+lGZDJHAOJmthByFCcyvsRUBttkOmlt6zIZqrRGG6LwhicFQgauPuplqhhUr3vmdqqRLqQs9/expAJo3iPxnyxTdeyf0T3d6ovv8GqI8q9Tv8kMEEOt7YfOkPEC2sUtQjJFwVW4PsfoE05YtwFUynI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730218645; c=relaxed/simple; bh=elYEmHlzbap6ByYfsIRLBptosxVFacCVdp1spbzk8Vg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EvYK6w8oLdz7AMTSw4LfUqjQ0qGBBlmsex2iqU3WpSQYcD04R3Nv49TpZzMYXmoPjfesX9xaVtk182htG7Wp4K045bEmuPm56Bw+hzKrzmxleDO/YvNrgxNBB1vvy48lSa3W6iwbzUDq9UfayK6L9BuVPvKfeYzulRae96vPNM4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=E/xw3gBX; arc=none smtp.client-ip=95.215.58.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="E/xw3gBX" Message-ID: <54b8ad89-5bac-475f-b655-942c7e6d60a2@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1730218636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ezYmkGlGSx9edqpDHAZhMKqx6HNJfpqrUbm2d+S7mr4=; b=E/xw3gBXRwoTD0j72Z0gRttCAx/mBKPcUud+4+geDwH4Eqs2A22gzw4CMWwQ/d46Eujxzj XSiKYbbnpgoWi1vhUpx4wE+nD6GUlCrdGSgsBnwTe2qqOjnVDwJCKRKQVqmnxWa27+cXqL YvXvTTothAJxiUTRN6UULge45yvhhCA= Date: Tue, 29 Oct 2024 16:17:10 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net-next v2 0/2] ptp: add control over HW timestamp latch point To: "Kubalewski, Arkadiusz" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "intel-wired-lan@lists.osuosl.org" Cc: "Nguyen, Anthony L" , "Kitszel, Przemyslaw" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "richardcochran@gmail.com" References: <20241028204755.1514189-1-arkadiusz.kubalewski@intel.com> <8899c12f-bc2f-49d3-bded-e838ac18fef8@linux.dev> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 29/10/2024 15:56, Kubalewski, Arkadiusz wrote: >> From: Vadim Fedorenko >> Sent: Tuesday, October 29, 2024 12:30 PM >> >> On 28/10/2024 20:47, Arkadiusz Kubalewski wrote: >>> HW support of PTP/timesync solutions in network PHY chips can be >>> achieved with two different approaches, the timestamp maybe latched >>> either in the beginning or after the Start of Frame Delimiter (SFD) [1]. >>> >>> Allow ptp device drivers to provide user with control over the timestamp >>> latch point. >>> >>> [1] https://www.ieee802.org/3/cx/public/april20/tse_3cx_01_0420.pdf >> >> I just wonder should we add ethtool interface to control this feature. >> As we are adding it for phy devices, it's good idea to have a way to >> control it through eth device too. WDYT? > > Seems doable, I guess somehow expand the controllability being added right > now with this series: > https://lore.kernel.org/netdev/20241023-feature_ptp_netnext-v18-0-ed948f3b6887@bootlin.com/#r > Or some other idea? Yeah, the series mentioned correlates with your work, that's why I asked about it. It would be great to be sure that the interface you are proposing can be reused or somehow combined with the series.