From: Stefan Agner <stefan@agner.ch>
To: shawnguo@kernel.org, s.hauer@pengutronix.de
Cc: max.krummenacher@toradex.com, marcel.ziswiler@toradex.com,
dev@pschenker.ch, kernel@pengutronix.de, fabio.estevam@nxp.com,
linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: imx6qdl-apalis: add phy-supply
Date: Mon, 21 Jan 2019 15:30:30 +0100 [thread overview]
Message-ID: <54c6b91cf908bd7553027d77244414f8@agner.ch> (raw)
In-Reply-To: <20190118133218.19917-1-stefan@agner.ch>
On 18.01.2019 14:32, Stefan Agner wrote:
> Use the VDD I/O rail as phy-supply regulator. Technically, the
> regulator has multiple rails, but currently the driver only
> supports a single phy-supply. The VDD I/O rail has the highest
> power consumption when software power down is used and hence
> the highest saving potential.
Please don't merge this patch. The vgen5_reg is also used as a pull-up
for USB ID pin, it would not be safe for the FEC driver to disable this
rail.
--
Stefan
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> arch/arm/boot/dts/imx6qdl-apalis.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> index 0b47aecf336a..cf66f9ececbd 100644
> --- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> @@ -241,6 +241,7 @@
> phy-handle = <ðphy>;
> phy-reset-duration = <10>;
> phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
> + phy-supply = <&vgen5_reg>;
> status = "okay";
>
> mdio {
prev parent reply other threads:[~2019-01-21 14:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 13:32 Stefan Agner
2019-01-21 8:35 ` Philippe Schenker
2019-01-21 14:30 ` Stefan Agner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54c6b91cf908bd7553027d77244414f8@agner.ch \
--to=stefan@agner.ch \
--cc=dev@pschenker.ch \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=max.krummenacher@toradex.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®